7:42 p.m.
Diff from v6: rebase to 6.9.0
v6: https://www.redhat.com/archives/libvir-list/2020-October/msg00707.html
gitlab repo: https://gitlab.com/hhan2/libvirt/-/commits/rbd-namespace-v7
Han Han (4):
qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE
util: Add member ns to the storage source struct
conf: Support to parse rbd namespace from source name
qemu: Implement rbd namespace to the source name attribute
docs/formatdomain.rst | 16 ++++++
src/conf/domain_conf.c | 47 ++++++++++++++++--
src/qemu/qemu_block.c | 1 +
src/qemu/qemu_capabilities.c | 4 ++
src/qemu/qemu_capabilities.h | 3 ++
src/qemu/qemu_domain.c | 8 +++
src/util/virstoragefile.c | 2 +
src/util/virstoragefile.h | 1 +
.../caps_5.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
.../caps_5.0.0.riscv64.xml | 1 +
.../caps_5.0.0.x86_64.xml | 1 +
.../caps_5.1.0.x86_64.xml | 1 +
.../caps_5.2.0.x86_64.xml | 1 +
...k-network-rbd-namespace.x86_64-latest.args | 49 +++++++++++++++++++
.../disk-network-rbd-namespace.xml | 40 +++++++++++++++
tests/qemuxml2argvtest.c | 1 +
...sk-network-rbd-namespace.x86_64-latest.xml | 49 +++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
19 files changed, 224 insertions(+), 4 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml
--
2.28.0
7:42 p.m.
New subject: [PATCH v7 1/4] qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE
The capability flag will be used for rbd namespace option. The rbd namespace
is introduced since ceph Nautilus and qemu v5.0.0.
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 4 ++++
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 +
8 files changed, 13 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 212ddf9206..b625463522 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -604,6 +604,9 @@ VIR_ENUM_IMPL(virQEMUCaps,
"block-export-add",
"netdev.vhost-vdpa",
"fsdev.createmode",
+
+ /* 385 */
+ "rbd.namespace",
);
@@ -1538,6 +1541,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] =
{
{ "migrate-set-parameters/arg-type/xbzrle-cache-size",
QEMU_CAPS_MIGRATION_PARAM_XBZRLE_CACHE_SIZE },
{ "set-numa-node/arg-type/+hmat-lb", QEMU_CAPS_NUMA_HMAT },
{ "netdev_add/arg-type/+vhost-vdpa", QEMU_CAPS_NETDEV_VHOST_VDPA },
+ { "blockdev-add/arg-type/+rbd/namespace", QEMU_CAPS_RBD_NAMESPACE },
};
typedef struct _virQEMUCapsObjectTypeProps virQEMUCapsObjectTypeProps;
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 6b40ff4f15..22037f5651 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -585,6 +585,9 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check
*/
QEMU_CAPS_NETDEV_VHOST_VDPA, /* -netdev vhost-vdpa*/
QEMU_CAPS_FSDEV_CREATEMODE, /* fsdev.createmode */
+ /* 385 */
+ QEMU_CAPS_RBD_NAMESPACE, /* -blockdev
'{"driver":"rbd",...,"namespace":str}' */
+
QEMU_CAPS_LAST /* this must always be the last item */
} virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
index 8e4e888cd4..319dbec0da 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
@@ -201,6 +201,7 @@
<flag name='numa.hmat'/>
<flag name='blockdev-hostdev-scsi'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5000000</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>61700241</microcodeVersion>
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
index e0519fe7eb..1bc131a42d 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
@@ -210,6 +210,7 @@
<flag name='numa.hmat'/>
<flag name='blockdev-hostdev-scsi'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5000000</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>42900241</microcodeVersion>
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
b/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
index c9f7a24282..e7623f792b 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
@@ -197,6 +197,7 @@
<flag name='numa.hmat'/>
<flag name='blockdev-hostdev-scsi'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5000000</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>0</microcodeVersion>
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
index c897bd3c63..5e12bf73d4 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
@@ -245,6 +245,7 @@
<flag name='numa.hmat'/>
<flag name='blockdev-hostdev-scsi'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5000000</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>43100241</microcodeVersion>
diff --git a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
index 8dd48812b9..165db60f96 100644
--- a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
@@ -247,6 +247,7 @@
<flag name='virtio-balloon.free-page-reporting'/>
<flag name='netdev.vhost-vdpa'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5001000</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>43100242</microcodeVersion>
diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
index 94a1945639..167b9bff42 100644
--- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
@@ -249,6 +249,7 @@
<flag name='block-export-add'/>
<flag name='netdev.vhost-vdpa'/>
<flag name='fsdev.createmode'/>
+ <flag name='rbd.namespace'/>
<version>5001050</version>
<kvmVersion>0</kvmVersion>
<microcodeVersion>43100243</microcodeVersion>
--
2.28.0
7:42 p.m.
New subject: [PATCH v7 2/4] util: Add member ns to the storage source struct
The member ns will be used to store the namespace string.
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/util/virstoragefile.c | 2 ++
src/util/virstoragefile.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 35e6dcf5de..5d2fd70889 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -2375,6 +2375,7 @@ virStorageSourceCopy(const virStorageSource *src,
def->path = g_strdup(src->path);
def->volume = g_strdup(src->volume);
+ def->ns = g_strdup(src->ns);
def->relPath = g_strdup(src->relPath);
def->backingStoreRaw = g_strdup(src->backingStoreRaw);
def->backingStoreRawFormat = src->backingStoreRawFormat;
@@ -2655,6 +2656,7 @@ virStorageSourceClear(virStorageSourcePtr def)
VIR_FREE(def->path);
VIR_FREE(def->volume);
+ VIR_FREE(def->ns);
VIR_FREE(def->snapshot);
VIR_FREE(def->configFile);
VIR_FREE(def->query);
diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h
index 87763cf389..8a6ddef8bf 100644
--- a/src/util/virstoragefile.h
+++ b/src/util/virstoragefile.h
@@ -284,6 +284,7 @@ struct _virStorageSource {
char *snapshot; /* for storage systems supporting internal snapshots */
char *configFile; /* some storage systems use config file as part of
the source definition */
+ char *ns; /* for the storage systems supporting namespace */
char *query; /* query string for HTTP based protocols */
size_t nhosts;
virStorageNetHostDefPtr hosts;
--
2.28.0
7:43 p.m.
New subject: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name
Signed-off-by: Han Han <hhan(a)redhat.com>
---
docs/formatdomain.rst | 16 ++++++++++++++
src/conf/domain_conf.c | 47 ++++++++++++++++++++++++++++++++++++++----
2 files changed, 59 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index a6ab845f92..2b760e6a39 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -2409,6 +2409,16 @@ paravirtualized driver is specified via the ``disk`` element.
</source>
<target dev='vde' bus='virtio'/>
</disk>
+ <disk type='network'>
+ <driver name="qemu" type="raw"/>
+ <source protocol="rbd" name="pool/namespace/image">
+ <host name="hostname" port="7000"/>
+ <auth username='myuser'>
+ <secret type='ceph' usage='mypassid'/>
+ </auth>
+ </source>
+ <target dev="vdf" bus="virtio"/>
+ </disk>
</devices>
...
@@ -2500,6 +2510,12 @@ paravirtualized driver is specified via the ``disk`` element.
the host by the ``nbd_tls`` and ``nbd_tls_x509_cert_dir`` in
/etc/libvirt/qemu.conf. ('tls' :since:`Since 4.5.0` )
+ For "rbd", the ``name`` attribute could be two formats: the format of
+ ``pool_name/image_name`` includes the rbd pool name and image name with
+ default rbd pool namespace; for the customized namespace, the format is
+ ``pool_name/namespace/image_name`` ( :since:`Since 6.9.0 and QEMU 5.0` ).
+ The pool name, namespace and image are separated by slash.
+
For protocols ``http`` and ``https`` an optional attribute ``query``
specifies the query string. ( :since:`Since 6.2.0` )
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d84d0327ad..a337051e30 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9554,6 +9554,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
g_autofree char *tlsCfg = NULL;
g_autofree char *sslverifystr = NULL;
xmlNodePtr tmpnode;
+ char **tmp_split_paths;
if (!(protocol = virXMLPropString(node, "protocol"))) {
virReportError(VIR_ERR_XML_ERROR, "%s",
@@ -9595,8 +9596,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
/* for historical reasons we store the volume and image name in one XML
* element although it complicates thing when attempting to access them. */
if (src->path &&
- (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER ||
- src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) {
+ src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER) {
char *tmp;
if (!(tmp = strchr(src->path, '/')) ||
tmp == src->path) {
@@ -9613,6 +9613,41 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
tmp[0] = '\0';
}
+ /* the name of rbd could be <pool>/<image> or
<pool>/<namespace>/<image> */
+ if (src->path &&
+ src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD &&
+ (tmp_split_paths = virStringSplit(src->path, "/", 3))) {
+ if (virStringIsEmpty(tmp_split_paths[0]) ||
+ !tmp_split_paths[1] ||
+ STREQ_NULLABLE(tmp_split_paths[2], "") ||
+ (virStringIsEmpty(tmp_split_paths[1]) &&
+ !tmp_split_paths[2])) {
+ virStringListFreeCount(tmp_split_paths, 3);
+ virReportError(VIR_ERR_XML_ERROR,
+ _("can't split path '%s' into pool name, pool
"
+ "namespace, image name OR pool name, image
name"),
+ src->path);
+ return -1;
+ }
+
+ VIR_FREE(src->path);
+ src->volume = g_strdup(tmp_split_paths[0]);
+ /* the format of <pool>/<image> */
+ if (!tmp_split_paths[2])
+ src->path = g_strdup(tmp_split_paths[1]);
+
+ if (tmp_split_paths[2]) {
+ /* the format of <pool>/<ns>/<image> */
+ if (STRNEQ_NULLABLE(tmp_split_paths[1], ""))
+ src->ns = g_strdup(tmp_split_paths[1]);
+
+ /* the format of <pool>//<image> */
+ src->path = g_strdup(tmp_split_paths[2]);
+ }
+
+ virStringListFreeCount(tmp_split_paths, 3);
+ }
+
/* snapshot currently works only for remote disks */
src->snapshot = virXPathString("string(./snapshot/@name)", ctxt);
@@ -25351,8 +25386,12 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf,
virBufferAsprintf(attrBuf, " protocol='%s'",
virStorageNetProtocolTypeToString(src->protocol));
- if (src->volume)
- path = g_strdup_printf("%s/%s", src->volume, src->path);
+ if (src->volume) {
+ if (src->ns)
+ path = g_strdup_printf("%s/%s/%s", src->volume, src->ns,
src->path);
+ else
+ path = g_strdup_printf("%s/%s", src->volume, src->path);
+ }
virBufferEscapeString(attrBuf, " name='%s'", path ? path :
src->path);
virBufferEscapeString(attrBuf, " query='%s'", src->query);
--
2.28.0
8:24 p.m.
New subject: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name
On Tue, Nov 10, 2020 at 8:43 PM Han Han <hhan(a)redhat.com> wrote:
Signed-off-by: Han Han <hhan(a)redhat.com>
---
docs/formatdomain.rst | 16 ++++++++++++++
src/conf/domain_conf.c | 47 ++++++++++++++++++++++++++++++++++++++----
2 files changed, 59 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index a6ab845f92..2b760e6a39 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -2409,6 +2409,16 @@ paravirtualized driver is specified via the ``disk`` element.
</source>
<target dev='vde' bus='virtio'/>
</disk>
+ <disk type='network'>
+ <driver name="qemu" type="raw"/>
+ <source protocol="rbd" name="pool/namespace/image">
+ <host name="hostname" port="7000"/>
+ <auth username='myuser'>
+ <secret type='ceph' usage='mypassid'/>
+ </auth>
+ </source>
+ <target dev="vdf" bus="virtio"/>
+ </disk>
</devices>
...
@@ -2500,6 +2510,12 @@ paravirtualized driver is specified via the ``disk`` element.
the host by the ``nbd_tls`` and ``nbd_tls_x509_cert_dir`` in
/etc/libvirt/qemu.conf. ('tls' :since:`Since 4.5.0` )
+ For "rbd", the ``name`` attribute could be two formats: the format of
+ ``pool_name/image_name`` includes the rbd pool name and image name with
+ default rbd pool namespace; for the customized namespace, the format is
+ ``pool_name/namespace/image_name`` ( :since:`Since 6.9.0 and QEMU 5.0` ).
+ The pool name, namespace and image are separated by slash.
+
For protocols ``http`` and ``https`` an optional attribute ``query``
specifies the query string. ( :since:`Since 6.2.0` )
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d84d0327ad..a337051e30 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9554,6 +9554,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
g_autofree char *tlsCfg = NULL;
g_autofree char *sslverifystr = NULL;
xmlNodePtr tmpnode;
+ char **tmp_split_paths;
if (!(protocol = virXMLPropString(node, "protocol"))) {
virReportError(VIR_ERR_XML_ERROR, "%s",
@@ -9595,8 +9596,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
/* for historical reasons we store the volume and image name in one XML
* element although it complicates thing when attempting to access them. */
if (src->path &&
- (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER ||
- src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) {
+ src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER) {
char *tmp;
if (!(tmp = strchr(src->path, '/')) ||
tmp == src->path) {
@@ -9613,6 +9613,41 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
tmp[0] = '\0';
}
+ /* the name of rbd could be <pool>/<image> or
<pool>/<namespace>/<image> */
+ if (src->path &&
+ src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD &&
+ (tmp_split_paths = virStringSplit(src->path, "/", 3))) {
+ if (virStringIsEmpty(tmp_split_paths[0]) ||
+ !tmp_split_paths[1] ||
+ STREQ_NULLABLE(tmp_split_paths[2], "") ||
+ (virStringIsEmpty(tmp_split_paths[1]) &&
+ !tmp_split_paths[2])) {
+ virStringListFreeCount(tmp_split_paths, 3);
+ virReportError(VIR_ERR_XML_ERROR,
+ _("can't split path '%s' into pool name,
pool "
+ "namespace, image name OR pool name, image
name"),
+ src->path);
+ return -1;
+ }
+
+ VIR_FREE(src->path);
+ src->volume = g_strdup(tmp_split_paths[0]);
+ /* the format of <pool>/<image> */
+ if (!tmp_split_paths[2])
+ src->path = g_strdup(tmp_split_paths[1]);
+
+ if (tmp_split_paths[2]) {
+ /* the format of <pool>/<ns>/<image> */
+ if (STRNEQ_NULLABLE(tmp_split_paths[1], ""))
+ src->ns = g_strdup(tmp_split_paths[1]);
+
+ /* the format of <pool>//<image> */
+ src->path = g_strdup(tmp_split_paths[2]);
Nit: I think QEMU and the rbd CLI will both treat this case as an
image named "/<image>" instead of "<image>".
Otherwise,
Reviewed-by: Jason Dillaman <dillaman(a)redhat.com>
+ }
+
+ virStringListFreeCount(tmp_split_paths, 3);
+ }
+
/* snapshot currently works only for remote disks */
src->snapshot = virXPathString("string(./snapshot/@name)", ctxt);
@@ -25351,8 +25386,12 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf,
virBufferAsprintf(attrBuf, " protocol='%s'",
virStorageNetProtocolTypeToString(src->protocol));
- if (src->volume)
- path = g_strdup_printf("%s/%s", src->volume, src->path);
+ if (src->volume) {
+ if (src->ns)
+ path = g_strdup_printf("%s/%s/%s", src->volume, src->ns,
src->path);
+ else
+ path = g_strdup_printf("%s/%s", src->volume, src->path);
+ }
virBufferEscapeString(attrBuf, " name='%s'", path ? path :
src->path);
virBufferEscapeString(attrBuf, " query='%s'", src->query);
--
2.28.0
--
Jason
11:37 p.m.
New subject: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name
On Wed, Nov 11, 2020 at 10:24 AM Jason Dillaman <jdillama(a)redhat.com> wrote:
On Tue, Nov 10, 2020 at 8:43 PM Han Han <hhan(a)redhat.com>
wrote:
>
> Signed-off-by: Han Han <hhan(a)redhat.com>
> ---
> docs/formatdomain.rst | 16 ++++++++++++++
> src/conf/domain_conf.c | 47 ++++++++++++++++++++++++++++++++++++++----
> 2 files changed, 59 insertions(+), 4 deletions(-)
>
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index a6ab845f92..2b760e6a39 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -2409,6 +2409,16 @@ paravirtualized driver is specified via the
``disk`` element.
> </source>
> <target dev='vde' bus='virtio'/>
> </disk>
> + <disk type='network'>
> + <driver name="qemu" type="raw"/>
> + <source protocol="rbd"
name="pool/namespace/image">
> + <host name="hostname" port="7000"/>
> + <auth username='myuser'>
> + <secret type='ceph' usage='mypassid'/>
> + </auth>
> + </source>
> + <target dev="vdf" bus="virtio"/>
> + </disk>
> </devices>
> ...
>
> @@ -2500,6 +2510,12 @@ paravirtualized driver is specified via the
``disk`` element.
> the host by the ``nbd_tls`` and ``nbd_tls_x509_cert_dir`` in
> /etc/libvirt/qemu.conf. ('tls' :since:`Since 4.5.0` )
>
> + For "rbd", the ``name`` attribute could be two formats: the
format of
> + ``pool_name/image_name`` includes the rbd pool name and image
name with
> + default rbd pool namespace; for the customized namespace, the
format is
> + ``pool_name/namespace/image_name`` ( :since:`Since 6.9.0 and QEMU
5.0` ).
> + The pool name, namespace and image are separated by slash.
> +
> For protocols ``http`` and ``https`` an optional attribute
``query``
> specifies the query string. ( :since:`Since 6.2.0` )
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index d84d0327ad..a337051e30 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -9554,6 +9554,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> g_autofree char *tlsCfg = NULL;
> g_autofree char *sslverifystr = NULL;
> xmlNodePtr tmpnode;
> + char **tmp_split_paths;
>
> if (!(protocol = virXMLPropString(node, "protocol"))) {
> virReportError(VIR_ERR_XML_ERROR, "%s",
> @@ -9595,8 +9596,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> /* for historical reasons we store the volume and image name in one
XML
> * element although it complicates thing when attempting to access
them. */
> if (src->path &&
> - (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER ||
> - src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) {
> + src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER) {
> char *tmp;
> if (!(tmp = strchr(src->path, '/')) ||
> tmp == src->path) {
> @@ -9613,6 +9613,41 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> tmp[0] = '\0';
> }
>
> + /* the name of rbd could be <pool>/<image> or
<pool>/<namespace>/<image> */
> + if (src->path &&
> + src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD &&
> + (tmp_split_paths = virStringSplit(src->path, "/", 3))) {
> + if (virStringIsEmpty(tmp_split_paths[0]) ||
> + !tmp_split_paths[1] ||
> + STREQ_NULLABLE(tmp_split_paths[2], "") ||
> + (virStringIsEmpty(tmp_split_paths[1]) &&
> + !tmp_split_paths[2])) {
> + virStringListFreeCount(tmp_split_paths, 3);
> + virReportError(VIR_ERR_XML_ERROR,
> + _("can't split path '%s' into pool
name,
pool "
> + "namespace, image name OR pool name, image
name"),
> + src->path);
> + return -1;
> + }
> +
> + VIR_FREE(src->path);
> + src->volume = g_strdup(tmp_split_paths[0]);
> + /* the format of <pool>/<image> */
> + if (!tmp_split_paths[2])
> + src->path = g_strdup(tmp_split_paths[1]);
> +
> + if (tmp_split_paths[2]) {
> + /* the format of <pool>/<ns>/<image> */
> + if (STRNEQ_NULLABLE(tmp_split_paths[1], ""))
> + src->ns = g_strdup(tmp_split_paths[1]);
> +
> + /* the format of <pool>//<image> */
> + src->path = g_strdup(tmp_split_paths[2]);
Nit: I think QEMU and the rbd CLI will both treat this case as an
image named "/<image>" instead of "<image>".
The results of qemu(qemu-kvm-5.1.0-5.fc33.x86_64) and rbd
CLI(ceph-common-15.2.5-1.fc33.x86_64)
are different here:
➜ ~ qemu-img info rbd:rbd//copy:conf=$HOME/.ceph/ceph.conf:key=XXXXXXXXXX
image: json:{"driver": "raw", "file": {"pool":
"rbd", "image": "copy",
"conf": "/home/hhan/.ceph/ceph.conf", "driver":
"rbd"}}
file format: raw
virtual size: 10 GiB (10737418240 bytes)
disk size: unavailable
cluster_size: 4194304
➜ ~ rbd info rbd//copy
rbd: error opening image /copy: (2) No such file or directory
➜ ~ rbd info rbd/copy
rbd image 'copy':
size 10 GiB in 2560 objects
order 22 (4 MiB objects)
snapshot_count: 0
id: 4a4956b8b4567
block_name_prefix: rbd_data.4a4956b8b4567
format: 2
features: layering, exclusive-lock, object-map, fast-diff,
deep-flatten
op_features:
flags:
create_timestamp: Tue Mar 17 15:43:38 2020
access_timestamp: Wed Nov 11 13:29:33 2020
modify_timestamp: Tue Mar 17 15:43:38 2020
I wonder which parsing pattern should be applied to in libvirt...
Otherwise,
Reviewed-by: Jason Dillaman <dillaman(a)redhat.com>
> + }
> +
> + virStringListFreeCount(tmp_split_paths, 3);
> + }
> +
> /* snapshot currently works only for remote disks */
> src->snapshot = virXPathString("string(./snapshot/@name)", ctxt);
>
> @@ -25351,8 +25386,12 @@ virDomainDiskSourceFormatNetwork(virBufferPtr
attrBuf,
> virBufferAsprintf(attrBuf, " protocol='%s'",
> virStorageNetProtocolTypeToString(src->protocol));
>
> - if (src->volume)
> - path = g_strdup_printf("%s/%s", src->volume, src->path);
> + if (src->volume) {
> + if (src->ns)
> + path = g_strdup_printf("%s/%s/%s", src->volume,
src->ns,
src->path);
> + else
> + path = g_strdup_printf("%s/%s", src->volume,
src->path);
> + }
>
> virBufferEscapeString(attrBuf, " name='%s'", path ? path :
src->path);
> virBufferEscapeString(attrBuf, " query='%s'",
src->query);
> --
> 2.28.0
>
--
Jason
7:36 a.m.
New subject: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name
On Wed, Nov 11, 2020 at 12:37 AM Han Han <hhan(a)redhat.com> wrote:
On Wed, Nov 11, 2020 at 10:24 AM Jason Dillaman <jdillama(a)redhat.com> wrote:
>
> On Tue, Nov 10, 2020 at 8:43 PM Han Han <hhan(a)redhat.com> wrote:
> >
> > Signed-off-by: Han Han <hhan(a)redhat.com>
> > ---
> > docs/formatdomain.rst | 16 ++++++++++++++
> > src/conf/domain_conf.c | 47 ++++++++++++++++++++++++++++++++++++++----
> > 2 files changed, 59 insertions(+), 4 deletions(-)
> >
> > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> > index a6ab845f92..2b760e6a39 100644
> > --- a/docs/formatdomain.rst
> > +++ b/docs/formatdomain.rst
> > @@ -2409,6 +2409,16 @@ paravirtualized driver is specified via the ``disk``
element.
> > </source>
> > <target dev='vde' bus='virtio'/>
> > </disk>
> > + <disk type='network'>
> > + <driver name="qemu" type="raw"/>
> > + <source protocol="rbd"
name="pool/namespace/image">
> > + <host name="hostname" port="7000"/>
> > + <auth username='myuser'>
> > + <secret type='ceph' usage='mypassid'/>
> > + </auth>
> > + </source>
> > + <target dev="vdf" bus="virtio"/>
> > + </disk>
> > </devices>
> > ...
> >
> > @@ -2500,6 +2510,12 @@ paravirtualized driver is specified via the ``disk``
element.
> > the host by the ``nbd_tls`` and ``nbd_tls_x509_cert_dir`` in
> > /etc/libvirt/qemu.conf. ('tls' :since:`Since 4.5.0` )
> >
> > + For "rbd", the ``name`` attribute could be two formats: the
format of
> > + ``pool_name/image_name`` includes the rbd pool name and image name with
> > + default rbd pool namespace; for the customized namespace, the format is
> > + ``pool_name/namespace/image_name`` ( :since:`Since 6.9.0 and QEMU 5.0`
).
> > + The pool name, namespace and image are separated by slash.
> > +
> > For protocols ``http`` and ``https`` an optional attribute ``query``
> > specifies the query string. ( :since:`Since 6.2.0` )
> >
> > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> > index d84d0327ad..a337051e30 100644
> > --- a/src/conf/domain_conf.c
> > +++ b/src/conf/domain_conf.c
> > @@ -9554,6 +9554,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> > g_autofree char *tlsCfg = NULL;
> > g_autofree char *sslverifystr = NULL;
> > xmlNodePtr tmpnode;
> > + char **tmp_split_paths;
> >
> > if (!(protocol = virXMLPropString(node, "protocol"))) {
> > virReportError(VIR_ERR_XML_ERROR, "%s",
> > @@ -9595,8 +9596,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> > /* for historical reasons we store the volume and image name in one XML
> > * element although it complicates thing when attempting to access them.
*/
> > if (src->path &&
> > - (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER ||
> > - src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) {
> > + src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER) {
> > char *tmp;
> > if (!(tmp = strchr(src->path, '/')) ||
> > tmp == src->path) {
> > @@ -9613,6 +9613,41 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node,
> > tmp[0] = '\0';
> > }
> >
> > + /* the name of rbd could be <pool>/<image> or
<pool>/<namespace>/<image> */
> > + if (src->path &&
> > + src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD &&
> > + (tmp_split_paths = virStringSplit(src->path, "/", 3))) {
> > + if (virStringIsEmpty(tmp_split_paths[0]) ||
> > + !tmp_split_paths[1] ||
> > + STREQ_NULLABLE(tmp_split_paths[2], "") ||
> > + (virStringIsEmpty(tmp_split_paths[1]) &&
> > + !tmp_split_paths[2])) {
> > + virStringListFreeCount(tmp_split_paths, 3);
> > + virReportError(VIR_ERR_XML_ERROR,
> > + _("can't split path '%s' into pool
name, pool "
> > + "namespace, image name OR pool name, image
name"),
> > + src->path);
> > + return -1;
> > + }
> > +
> > + VIR_FREE(src->path);
> > + src->volume = g_strdup(tmp_split_paths[0]);
> > + /* the format of <pool>/<image> */
> > + if (!tmp_split_paths[2])
> > + src->path = g_strdup(tmp_split_paths[1]);
> > +
> > + if (tmp_split_paths[2]) {
> > + /* the format of <pool>/<ns>/<image> */
> > + if (STRNEQ_NULLABLE(tmp_split_paths[1], ""))
> > + src->ns = g_strdup(tmp_split_paths[1]);
> > +
> > + /* the format of <pool>//<image> */
> > + src->path = g_strdup(tmp_split_paths[2]);
>
> Nit: I think QEMU and the rbd CLI will both treat this case as an
> image named "/<image>" instead of "<image>".
The results of qemu(qemu-kvm-5.1.0-5.fc33.x86_64) and rbd
CLI(ceph-common-15.2.5-1.fc33.x86_64)
are different here:
➜ ~ qemu-img info rbd:rbd//copy:conf=$HOME/.ceph/ceph.conf:key=XXXXXXXXXX
image: json:{"driver": "raw", "file": {"pool":
"rbd", "image": "copy", "conf":
"/home/hhan/.ceph/ceph.conf", "driver": "rbd"}}
file format: raw
virtual size: 10 GiB (10737418240 bytes)
disk size: unavailable
cluster_size: 4194304
➜ ~ rbd info rbd//copy
rbd: error opening image /copy: (2) No such file or directory
➜ ~ rbd info rbd/copy
rbd image 'copy':
size 10 GiB in 2560 objects
order 22 (4 MiB objects)
snapshot_count: 0
id: 4a4956b8b4567
block_name_prefix: rbd_data.4a4956b8b4567
format: 2
features: layering, exclusive-lock, object-map, fast-diff, deep-flatten
op_features:
flags:
create_timestamp: Tue Mar 17 15:43:38 2020
access_timestamp: Wed Nov 11 13:29:33 2020
modify_timestamp: Tue Mar 17 15:43:38 2020
I wonder which parsing pattern should be applied to in libvirt...
If it matches QEMU, disregard my nit -- it's already an edge case.
Thanks.
>
>
> Otherwise,
>
> Reviewed-by: Jason Dillaman <dillaman(a)redhat.com>
>
>
> > + }
> > +
> > + virStringListFreeCount(tmp_split_paths, 3);
> > + }
> > +
> > /* snapshot currently works only for remote disks */
> > src->snapshot = virXPathString("string(./snapshot/@name)",
ctxt);
> >
> > @@ -25351,8 +25386,12 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf,
> > virBufferAsprintf(attrBuf, " protocol='%s'",
> > virStorageNetProtocolTypeToString(src->protocol));
> >
> > - if (src->volume)
> > - path = g_strdup_printf("%s/%s", src->volume,
src->path);
> > + if (src->volume) {
> > + if (src->ns)
> > + path = g_strdup_printf("%s/%s/%s", src->volume,
src->ns, src->path);
> > + else
> > + path = g_strdup_printf("%s/%s", src->volume,
src->path);
> > + }
> >
> > virBufferEscapeString(attrBuf, " name='%s'", path ? path
: src->path);
> > virBufferEscapeString(attrBuf, " query='%s'",
src->query);
> > --
> > 2.28.0
> >
>
>
> --
> Jason
>
--
Jason
7:43 p.m.
New subject: [PATCH v7 4/4] qemu: Implement rbd namespace to the source name attribute
Since Nautilus ceph supports separate image namespaces within a pool for
tenant isolation and QEMU adds it as a rbd blockdev options from 5.0.0.
The source name with format "<pool>/<namespace>/<image>" could
be used to
access a rbd image with namespace.
Add unit tests for this attribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1816909
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/qemu/qemu_block.c | 1 +
src/qemu/qemu_domain.c | 8 +++
...k-network-rbd-namespace.x86_64-latest.args | 49 +++++++++++++++++++
.../disk-network-rbd-namespace.xml | 40 +++++++++++++++
tests/qemuxml2argvtest.c | 1 +
...sk-network-rbd-namespace.x86_64-latest.xml | 49 +++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
7 files changed, 149 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 4640e339c0..a1d85d3794 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -870,6 +870,7 @@ qemuBlockStorageSourceGetRBDProps(virStorageSourcePtr src,
"s:pool", src->volume,
"s:image", src->path,
"S:snapshot", src->snapshot,
+ "S:namespace", src->ns,
"S:conf", src->configFile,
"A:server", &servers,
"S:user", username,
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 02b5e7422c..9c21f564ce 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4628,6 +4628,14 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src,
return -1;
}
+ if (src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD &&
+ src->ns &&
+ !virQEMUCapsGet(qemuCaps, QEMU_CAPS_RBD_NAMESPACE)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("rbd namespace is not supported by this QEMU"));
+ return -1;
+ }
+
return 0;
}
diff --git a/tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args
b/tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args
new file mode 100644
index 0000000000..49b3dd53f6
--- /dev/null
+++ b/tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args
@@ -0,0 +1,49 @@
+LC_ALL=C \
+PATH=/bin \
+HOME=/tmp/lib/domain--1-QEMUGuest1 \
+USER=test \
+LOGNAME=test \
+XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \
+XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \
+XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \
+QEMU_AUDIO_DRV=none \
+/usr/bin/qemu-system-x86_64 \
+-name guest=QEMUGuest1,debug-threads=on \
+-S \
+-object secret,id=masterKey0,format=raw,\
+file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
+-machine pc,accel=tcg,usb=off,dump-guest-core=off,memory-backend=pc.ram \
+-cpu qemu64 \
+-m 214 \
+-object memory-backend-ram,id=pc.ram,size=224395264 \
+-overcommit mem-lock=off \
+-smp 1,sockets=1,cores=1,threads=1 \
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=charmonitor,fd=1729,server,nowait \
+-mon chardev=charmonitor,id=monitor,mode=control \
+-rtc base=utc \
+-no-shutdown \
+-no-acpi \
+-boot strict=on \
+-device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
+-blockdev
'{"driver":"rbd","pool":"pool","image":"image","namespace":"ns",\
+"server":[{"host":"mon1.example.org","port":"6321"},{"host":"mon2.example.org",\
+"port":"6322"},{"host":"mon3.example.org","port":"6322"}],\
+"node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}'
\
+-blockdev
'{"node-name":"libvirt-2-format","read-only":false,"driver":"raw",\
+"file":"libvirt-2-storage"}' \
+-device virtio-blk-pci,bus=pci.0,addr=0x2,drive=libvirt-2-format,\
+id=virtio-disk0,bootindex=1 \
+-blockdev
'{"driver":"rbd","pool":"pool","image":"image",\
+"server":[{"host":"mon1.example.org","port":"6321"}],\
+"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}'
\
+-blockdev
'{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\
+"file":"libvirt-1-storage"}' \
+-device virtio-blk-pci,bus=pci.0,addr=0x3,drive=libvirt-1-format,\
+id=virtio-disk1 \
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\
+resourcecontrol=deny \
+-msg timestamp=on
diff --git a/tests/qemuxml2argvdata/disk-network-rbd-namespace.xml
b/tests/qemuxml2argvdata/disk-network-rbd-namespace.xml
new file mode 100644
index 0000000000..5389cbda2f
--- /dev/null
+++ b/tests/qemuxml2argvdata/disk-network-rbd-namespace.xml
@@ -0,0 +1,40 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='x86_64' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-x86_64</emulator>
+ <disk type='network' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source protocol='rbd' name='pool/ns/image'>
+ <host name='mon1.example.org' port='6321'/>
+ <host name='mon2.example.org' port='6322'/>
+ <host name='mon3.example.org' port='6322'/>
+ </source>
+ <target dev='vda' bus='virtio'/>
+ </disk>
+ <disk type='network' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source protocol='rbd' name='pool//image'>
+ <host name='mon1.example.org' port='6321'/>
+ </source>
+ <target dev='vdb' bus='virtio'/>
+ </disk>
+ <controller type='usb' index='0'/>
+ <controller type='ide' index='0'/>
+ <controller type='pci' index='0' model='pci-root'/>
+ <input type='mouse' bus='ps2'/>
+ <input type='keyboard' bus='ps2'/>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index ec33134a97..83f8f8f01f 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -1232,6 +1232,7 @@ mymain(void)
DO_TEST_CAPS_VER("disk-network-rbd", "2.5.0");
DO_TEST_CAPS_VER("disk-network-rbd", "2.12.0");
DO_TEST_CAPS_LATEST("disk-network-rbd");
+ DO_TEST_CAPS_LATEST("disk-network-rbd-namespace");
DO_TEST_FAILURE("disk-network-rbd-no-colon", NONE);
DO_TEST("disk-network-sheepdog", NONE);
DO_TEST_CAPS_VER("disk-network-sheepdog", "2.12.0");
diff --git a/tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml
b/tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml
new file mode 100644
index 0000000000..8bc26e2764
--- /dev/null
+++ b/tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml
@@ -0,0 +1,49 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='x86_64' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <cpu mode='custom' match='exact' check='none'>
+ <model fallback='forbid'>qemu64</model>
+ </cpu>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-x86_64</emulator>
+ <disk type='network' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source protocol='rbd' name='pool/ns/image'>
+ <host name='mon1.example.org' port='6321'/>
+ <host name='mon2.example.org' port='6322'/>
+ <host name='mon3.example.org' port='6322'/>
+ </source>
+ <target dev='vda' bus='virtio'/>
+ <address type='pci' domain='0x0000' bus='0x00'
slot='0x02' function='0x0'/>
+ </disk>
+ <disk type='network' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source protocol='rbd' name='pool/image'>
+ <host name='mon1.example.org' port='6321'/>
+ </source>
+ <target dev='vdb' bus='virtio'/>
+ <address type='pci' domain='0x0000' bus='0x00'
slot='0x03' function='0x0'/>
+ </disk>
+ <controller type='usb' index='0' model='piix3-uhci'>
+ <address type='pci' domain='0x0000' bus='0x00'
slot='0x01' function='0x2'/>
+ </controller>
+ <controller type='ide' index='0'>
+ <address type='pci' domain='0x0000' bus='0x00'
slot='0x01' function='0x1'/>
+ </controller>
+ <controller type='pci' index='0' model='pci-root'/>
+ <input type='mouse' bus='ps2'/>
+ <input type='keyboard' bus='ps2'/>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index c006719dee..b3f25f2751 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -297,6 +297,7 @@ mymain(void)
QEMU_CAPS_SCSI_BLOCK);
DO_TEST("disk-network-gluster", NONE);
DO_TEST("disk-network-rbd", NONE);
+ DO_TEST_CAPS_ARCH_LATEST("disk-network-rbd-namespace",
"x86_64");
DO_TEST("disk-network-source-auth", NONE);
DO_TEST("disk-network-sheepdog", NONE);
DO_TEST("disk-network-vxhs", NONE);
--
2.28.0
1472
days inactive
1472
days old
7 comments
2 participants
participants (2)
-
Han Han -
Jason Dillaman