9:08 a.m.
Hopefully pushed as trivial by the time you're reading this message.
Ján Tomko (2):
qemu: free migEvent in qemuMigrationCapsCheck
conf: fix vsock memory leaks
src/conf/domain_conf.c | 2 ++
src/qemu/qemu_migration_params.c | 1 +
2 files changed, 3 insertions(+)
--
2.16.1
9:08 a.m.
New subject: [libvirt] [PATCH 1/2] qemu: free migEvent in qemuMigrationCapsCheck
We allocate a temporary bitmap but never free it.
Introduced by <commit 1f8a1a9>:
qemu: Do not use qemuMonitorSetMigrationCapability
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/qemu/qemu_migration_params.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 578cd6671f..2083563d32 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -1343,6 +1343,7 @@ qemuMigrationCapsCheck(virQEMUDriverPtr driver,
ret = 0;
cleanup:
+ virBitmapFree(migEvent);
virJSONValueFree(json);
virStringListFree(caps);
return ret;
--
2.16.1
9:20 a.m.
New subject: [libvirt] [PATCH 1/2] qemu: free migEvent in qemuMigrationCapsCheck
On Wed, May 30, 2018 at 16:08:06 +0200, Ján Tomko wrote:
We allocate a temporary bitmap but never free it.
Introduced by <commit 1f8a1a9>:
qemu: Do not use qemuMonitorSetMigrationCapability
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/qemu/qemu_migration_params.c | 1 +
1 file changed, 1 insertion(+)
ACK
9:08 a.m.
New subject: [libvirt] [PATCH 2/2] conf: fix vsock memory leaks
Introduced by:
commit d4abb7b45d48aba77c2464dbea95f02a43a60834
conf: introduce <vsock> element
commit b8b42ca036adbfaac1741c8efe389cd1403e220b
qemu: add support for vhost-vsock-pci
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 544f63a2a9..27e2bd50eb 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2062,6 +2062,7 @@ virDomainVsockDefFree(virDomainVsockDefPtr vsock)
return;
virObjectUnref(vsock->privateData);
+ virDomainDeviceInfoClear(&vsock->info);
VIR_FREE(vsock);
}
@@ -3092,6 +3093,7 @@ void virDomainDefFree(virDomainDefPtr def)
virDomainMemballoonDefFree(def->memballoon);
virDomainNVRAMDefFree(def->nvram);
+ virDomainVsockDefFree(def->vsock);
for (i = 0; i < def->mem.nhugepages; i++)
virBitmapFree(def->mem.hugepages[i].nodemask);
--
2.16.1
9:21 a.m.
New subject: [libvirt] [PATCH 2/2] conf: fix vsock memory leaks
On Wed, May 30, 2018 at 16:08:07 +0200, Ján Tomko wrote:
Introduced by:
commit d4abb7b45d48aba77c2464dbea95f02a43a60834
conf: introduce <vsock> element
commit b8b42ca036adbfaac1741c8efe389cd1403e220b
qemu: add support for vhost-vsock-pci
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 544f63a2a9..27e2bd50eb 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2062,6 +2062,7 @@ virDomainVsockDefFree(virDomainVsockDefPtr vsock)
return;
virObjectUnref(vsock->privateData);
+ virDomainDeviceInfoClear(&vsock->info);
VIR_FREE(vsock);
}
@@ -3092,6 +3093,7 @@ void virDomainDefFree(virDomainDefPtr def)
virDomainMemballoonDefFree(def->memballoon);
virDomainNVRAMDefFree(def->nvram);
+ virDomainVsockDefFree(def->vsock);
Oops, I was pretty sure I've seen this ... probably hallucinations.
for (i = 0; i < def->mem.nhugepages; i++)
virBitmapFree(def->mem.hugepages[i].nodemask);
ACK
2369
days inactive
2369
days old
4 comments
2 participants
participants (2)
-
Ján Tomko -
Peter Krempa