10:23 a.m.
from src/qemu/qemu_command.c:
if (disk->discard) {
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_DISCARD)) {
virBufferAsprintf(&opt, ",discard=%s",
virDomainDiskDiscardTypeToString(disk->discard));
} else {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("discard is not supported by this QEMU binary"));
goto error;
}
}
However there appears to be no way to tell programmatically if the
qemu binary supports discard (ie. via libvirt). Therefore libguestfs
can never know when it is safe to use this option in the XML.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
5:19 p.m.
On Sun, Mar 09, 2014 at 03:23:25PM +0000, Richard W.M. Jones wrote:
from src/qemu/qemu_command.c:
if (disk->discard) {
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_DISCARD)) {
virBufferAsprintf(&opt, ",discard=%s",
virDomainDiskDiscardTypeToString(disk->discard));
} else {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("discard is not supported by this QEMU binary"));
goto error;
}
}
However there appears to be no way to tell programmatically if the
qemu binary supports discard (ie. via libvirt). Therefore libguestfs
can never know when it is safe to use this option in the XML.
Many of these requests/issues are appearing lately. Can we dump qemu
caps with normal capablities with e.g. "virsh capabilities --verbose"?
We have to keep the strings used consitent anyway since it's used in
migration data and so on.
Martin
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
5:30 a.m.
On Sun, Mar 09, 2014 at 11:19:47PM +0100, Martin Kletzander wrote:
On Sun, Mar 09, 2014 at 03:23:25PM +0000, Richard W.M. Jones wrote:
> from src/qemu/qemu_command.c:
>
> if (disk->discard) {
> if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_DISCARD)) {
> virBufferAsprintf(&opt, ",discard=%s",
> virDomainDiskDiscardTypeToString(disk->discard));
> } else {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> _("discard is not supported by this QEMU
binary"));
> goto error;
> }
> }
>
> However there appears to be no way to tell programmatically if the
> qemu binary supports discard (ie. via libvirt). Therefore libguestfs
> can never know when it is safe to use this option in the XML.
>
Many of these requests/issues are appearing lately. Can we dump qemu
caps with normal capablities with e.g. "virsh capabilities --verbose"?
We have to keep the strings used consitent anyway since it's used in
migration data and so on.
Stability isn't the only concern for the public API. The representation
of the data is just as important if not more so. The QEMU capabilities
are intimately related to the QEMU command line arg syntax, so not at
all suitable for the public API.
We need to consider logical features individually and determine how
to expose info about their hypervisor support matrix.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
3913
days inactive
3914
days old
2 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Martin Kletzander -
Richard W.M. Jones