3:52 a.m.
Hi,
qemu_driver misses some conversions to a char* before printing the uuid.
Possible fix attached.
Cheers,
-- Guido
4:29 p.m.
On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote:
Hi,
qemu_driver misses some conversions to a char* before printing the uuid.
Possible fix attached.
ACK, surprised that the printf() format checks don't complain about
passing an unsigned char to a %s format in GCC. This is actually
one of the things ICC flagged when i tried it, but I never fixed it
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
5:02 p.m.
On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote:
On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote:
> Hi,
> qemu_driver misses some conversions to a char* before printing the uuid.
> Possible fix attached.
ACK, surprised that the printf() format checks don't complain about
passing an unsigned char to a %s format in GCC. This is actually
one of the things ICC flagged when i tried it, but I never fixed it
Applied, i just had to add an include for uuid.h to avoid an undeclared
function warning :-)
thanks again
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
9:56 p.m.
On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote:
On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote:
> On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote:
> > Hi,
> > qemu_driver misses some conversions to a char* before printing the uuid.
> > Possible fix attached.
>
> ACK, surprised that the printf() format checks don't complain about
> passing an unsigned char to a %s format in GCC. This is actually
> one of the things ICC flagged when i tried it, but I never fixed it
Applied, i just had to add an include for uuid.h to avoid an undeclared
function warning :-)
The hunk including uuid.h accidently endet up in
0001-also-check-domain-uuid-on-create.patch, sorry about that.
-- Guido
11:46 p.m.
On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote:
On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote:
> On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote:
> > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote:
> > > Hi,
> > > qemu_driver misses some conversions to a char* before printing the uuid.
> > > Possible fix attached.
> >
> > ACK, surprised that the printf() format checks don't complain about
> > passing an unsigned char to a %s format in GCC. This is actually
> > one of the things ICC flagged when i tried it, but I never fixed it
>
> Applied, i just had to add an include for uuid.h to avoid an undeclared
> function warning :-)
The hunk including uuid.h accidently endet up in
0001-also-check-domain-uuid-on-create.patch, sorry about that.
Hum, i don't find it. Can you regenerate/repost please ?
thanks,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
4:09 a.m.
On Fri, Jul 25, 2008 at 11:46:48AM -0400, Daniel Veillard wrote:
On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote:
> On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote:
> > On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote:
> > > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote:
> > > > Hi,
> > > > qemu_driver misses some conversions to a char* before printing the
uuid.
> > > > Possible fix attached.
> > >
> > > ACK, surprised that the printf() format checks don't complain about
> > > passing an unsigned char to a %s format in GCC. This is actually
> > > one of the things ICC flagged when i tried it, but I never fixed it
> >
> > Applied, i just had to add an include for uuid.h to avoid an undeclared
> > function warning :-)
> The hunk including uuid.h accidently endet up in
> 0001-also-check-domain-uuid-on-create.patch, sorry about that.
Hum, i don't find it. Can you regenerate/repost please ?
Attached. It also
dropped the check if the domain is running or not,
since a transient domain with of a currently offline domain is just to
confusing.
-- Guido
8:54 p.m.
On Fri, Jul 25, 2008 at 04:09:31PM -0400, Guido Günther wrote:
[PATCH] also check domain uuid on create
and don't care if domain is active or not - it confuses users both ways
Okay, that looks reasonnable to me, applied and commited,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
5937
days inactive
5941
days old
6 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Guido Günther