2:57 a.m.
I think there is a unnecessary code for setting cpus parameter at
xenXMParseXMLToConfig, since the cpus parameter is already set on
the upper code. Because of this, converted cpus string will not be
used. So, can I remove it ?
Regards,
Saori Fukuta
4:29 a.m.
New subject: [Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig
Saori Fukuta wrote:
I think there is a unnecessary code for setting cpus parameter at
xenXMParseXMLToConfig, since the cpus parameter is already set on
the upper code. Because of this, converted cpus string will not be
used. So, can I remove it ?
Yes I agree, this code does seem to duplicate setting the "cpus"
configuration file entry.
If no one else disagrees, I'll commit this next week.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
8:34 a.m.
On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote:
I think there is a unnecessary code for setting cpus parameter at
xenXMParseXMLToConfig, since the cpus parameter is already set on
the upper code. Because of this, converted cpus string will not be
used. So, can I remove it ?
ACK
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
9:31 a.m.
On Fri, Dec 14, 2007 at 02:34:34PM +0000, Daniel P. Berrange wrote:
On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote:
> I think there is a unnecessary code for setting cpus parameter at
> xenXMParseXMLToConfig, since the cpus parameter is already set on
> the upper code. Because of this, converted cpus string will not be
> used. So, can I remove it ?
ACK
Okay, I will commit those 2 patches,
Saori, thanks a lot !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
9:52 a.m.
On Fri, Dec 14, 2007 at 10:31:58AM -0500, Daniel Veillard wrote:
On Fri, Dec 14, 2007 at 02:34:34PM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote:
> > I think there is a unnecessary code for setting cpus parameter at
> > xenXMParseXMLToConfig, since the cpus parameter is already set on
> > the upper code. Because of this, converted cpus string will not be
> > used. So, can I remove it ?
>
> ACK
Okay, I will commit those 2 patches,
Done,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
6189
days inactive
6189
days old
4 comments
4 participants
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones -
Saori Fukuta