7:16 a.m.
Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0
macros were scattered in various places, duplicated once (or twice)
per generated binaries. This patch moves everything in one virtlog.h
header, one virtlog.c file and set up the makefiles so that the
various binaries refers to the same bits.
That's a cleanup with no functional change to prepare the real
loging APIs, patch and the 2 new files attached,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
8:17 a.m.
On Thu, Nov 06, 2008 at 02:16:52PM +0100, Daniel Veillard wrote:
Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0
macros were scattered in various places, duplicated once (or twice)
per generated binaries. This patch moves everything in one virtlog.h
header, one virtlog.c file and set up the makefiles so that the
various binaries refers to the same bits.
That's a cleanup with no functional change to prepare the real
loging APIs, patch and the 2 new files attached,
ACK, this seems like a good idea considering we'll have more logging
stuff in the future. I'd prefer to drop the 'virt' prefix though and
just call it 'logging.c' or 'log.c'
Perhaps we should have a virLogInitialize() method todo the stuff
like getenv("LIBVIRT_DEBUG") that's currently in virInitialize().
eg, just make virInitialize() call virLogInitialize() for setup
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
8:33 a.m.
On Thu, Nov 06, 2008 at 02:17:49PM +0000, Daniel P. Berrange wrote:
On Thu, Nov 06, 2008 at 02:16:52PM +0100, Daniel Veillard wrote:
> Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0
> macros were scattered in various places, duplicated once (or twice)
> per generated binaries. This patch moves everything in one virtlog.h
> header, one virtlog.c file and set up the makefiles so that the
> various binaries refers to the same bits.
> That's a cleanup with no functional change to prepare the real
> loging APIs, patch and the 2 new files attached,
ACK, this seems like a good idea considering we'll have more logging
stuff in the future. I'd prefer to drop the 'virt' prefix though and
just call it 'logging.c' or 'log.c'
Okay, I don't really care for the name, except I was wondering about log.h
and since we prefer to align .c and .h names ...
wei:~/libvirt/src -> locate /log.h | wc -l
14
okay most of them come from kernel source headers, but things like
/usr/include/avahi-core/log.h
make me feel that a virt prefix is safer ...
Perhaps we should have a virLogInitialize() method todo the stuff
like getenv("LIBVIRT_DEBUG") that's currently in virInitialize().
eg, just make virInitialize() call virLogInitialize() for setup
Yup, that's one of the things to do, it's just an initial refactoring
to ease doing the cleanup and extensions.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
10:46 a.m.
On Thu, Nov 06, 2008 at 03:33:10PM +0100, Daniel Veillard wrote:
On Thu, Nov 06, 2008 at 02:17:49PM +0000, Daniel P. Berrange wrote:
> On Thu, Nov 06, 2008 at 02:16:52PM +0100, Daniel Veillard wrote:
> > Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0
> > macros were scattered in various places, duplicated once (or twice)
> > per generated binaries. This patch moves everything in one virtlog.h
> > header, one virtlog.c file and set up the makefiles so that the
> > various binaries refers to the same bits.
> > That's a cleanup with no functional change to prepare the real
> > loging APIs, patch and the 2 new files attached,
>
> ACK, this seems like a good idea considering we'll have more logging
> stuff in the future. I'd prefer to drop the 'virt' prefix though and
> just call it 'logging.c' or 'log.c'
Okay, I don't really care for the name, except I was wondering about log.h
and since we prefer to align .c and .h names ...
Okay, commited using logging.[ch]
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
5860
days inactive
5860
days old
3 comments
2 participants
participants (2)
-
Daniel P. Berrange -
Daniel Veillard