2:25 p.m.
Addressing my review comments from round 1, and introducing a few
more goodies along the way. I've added some syntax checks to
make it easier to stick with this style in the future.
v1 was at https://www.redhat.com/archives/libvir-list/2011-July/msg00264.html,
with patches 1-5 already applied, and patches 6-20 of that series revamped
in this series as 5-19. Patches 1-4 and 20-27 in this series are new.
Eric Blake (27):
maint: exclude more files from syntax check
maint: print flags in hex during debug
build: also check qemu_protocol for on-the-wire stability
libvirt-qemu: use unsigned flags
util: reject unknown flags, and prefer unsigned flags
node_device: reject unknown flags
storage: reject unknown flags
esx: reject unknown flags
libxl: reject unknown flags
lxc: reject unknown flags
openvz: reject unknown flags
phyp: reject unknown flags
qemu: reject unknown flags
test: reject unknown flags
uml: reject unknown flags
vbox: reject unknown flags
vmware: reject unknown flags
xen: reject unknown flags
xenapi: reject unknown flags
virsh, daemon: prefer unsigned flags
node_device: avoid implicit int
python: prefer unsigned flags
conf: prefer unsigned flags
build: don't hand-roll cloexec code
conf: delete unused flags arguments
remote: prefer unsigned flags
build: add syntax check for proper flags use
cfg.mk | 49 +++++++++---
daemon/remote.c | 2 +-
python/libvirt-override.c | 6 +-
src/Makefile.am | 20 +++--
src/conf/cpu_conf.c | 6 +-
src/conf/cpu_conf.h | 6 +-
src/conf/domain_conf.c | 24 ++----
src/conf/node_device_conf.h | 58 +++++++-------
src/conf/storage_conf.c | 4 +-
src/datatypes.h | 4 +-
src/esx/esx_device_monitor.c | 4 +-
src/esx/esx_driver.c | 28 +++++--
src/esx/esx_interface_driver.c | 4 +-
src/esx/esx_network_driver.c | 4 +-
src/esx/esx_nwfilter_driver.c | 4 +-
src/esx/esx_secret_driver.c | 4 +-
src/esx/esx_storage_driver.c | 4 +-
src/fdstream.c | 28 +++---
src/fdstream.h | 6 +-
src/interface/netcf_driver.c | 16 +++-
src/libvirt-qemu.c | 5 +-
src/libxl/libxl_driver.c | 18 +++-
src/locking/lock_driver_nop.c | 13 ++--
src/locking/lock_driver_sanlock.c | 3 +-
src/locking/lock_manager.c | 18 +++--
src/lxc/lxc_container.c | 4 +-
src/lxc/lxc_driver.c | 12 ++-
src/network/bridge_driver.c | 9 ++-
src/node_device/node_device_driver.c | 18 +++-
src/node_device/node_device_hal.c | 4 +-
src/node_device/node_device_udev.c | 4 +-
src/nodeinfo.h | 6 +-
src/nwfilter/nwfilter_driver.c | 4 +-
src/openvz/openvz_driver.c | 9 ++-
src/phyp/phyp_driver.c | 12 ++-
src/qemu/qemu_domain.c | 21 +++---
src/qemu/qemu_domain.h | 4 +-
src/qemu/qemu_driver.c | 30 +++++--
src/qemu/qemu_migration.c | 32 ++++----
src/qemu/qemu_monitor.c | 10 +-
src/qemu_protocol-structs | 14 +++
src/remote/qemu_protocol.x | 4 +-
src/remote/remote_driver.c | 6 +-
src/rpc/virnetserverclient.c | 2 +-
src/secret/secret_driver.c | 17 +++-
src/storage/storage_backend.c | 12 ++-
src/storage/storage_backend_disk.c | 10 ++-
src/storage/storage_backend_fs.c | 26 +++++--
src/storage/storage_backend_iscsi.c | 4 +-
src/storage/storage_backend_logical.c | 18 +++-
src/storage/storage_driver.c | 45 ++++++++--
src/test/test_driver.c | 144 +++++++++++++++++++++++++-------
src/uml/uml_driver.c | 33 +++-----
src/util/bridge.c | 19 +---
src/util/command.c | 18 ++--
src/util/iohelper.c | 18 ++--
src/util/logging.c | 13 +++-
src/util/logging.h | 8 +-
src/util/util.c | 14 ++--
src/vbox/vbox_driver.c | 5 +-
src/vbox/vbox_tmpl.c | 44 ++++++++--
src/vmware/vmware_driver.c | 17 +++-
src/xen/xen_driver.c | 12 ++-
src/xen/xen_hypervisor.c | 8 ++-
src/xen/xen_inotify.c | 4 +-
src/xen/xend_internal.c | 23 ++++--
src/xen/xend_internal.h | 3 +-
src/xen/xm_internal.c | 11 ++-
src/xen/xm_internal.h | 2 +-
src/xen/xs_internal.c | 12 ++-
src/xenapi/xenapi_driver.c | 13 +++-
tools/virsh.c | 2 +-
72 files changed, 731 insertions(+), 367 deletions(-)
create mode 100644 src/qemu_protocol-structs
--
1.7.4.4