Re: [libvirt] [PATCH] don't raise a missing network as an internal error

On Tue, Jul 07, 2009 at 03:16:43PM +0100, Daniel P. Berrange wrote: Agreed, removing the two lines we get: [root@paphio ~]# virsh create /tmp/bug.xml error: Failed to create domain from /tmp/bug.xml error: Network not found: no network with matching name instead of [root@paphio ~]# virsh create /tmp/bug.xml error: Failed to create domain from /tmp/bug.xml error: Network not found: Network 'defaut' not defined so the error is the one reported by the lookup and it should be that way, it's missing the name being looked at though, but it's something which need to be fixed more globally, as it shows up in a number of places as a grep will report: paphio:~/libvirt -> grep "with matching name" src/*.c src/network_driver.c: "%s", _("no network with matching name")); src/node_device.c: "%s", _("no node device with matching name")); src/node_device.c: "%s", _("no node device with matching name")); src/node_device.c: "%s", _("no node device with matching name")); src/node_device.c: "%s", _("no node device with matching name")); src/qemu_driver.c: _("no domain with matching name '%s'"), name); src/qemu_driver.c: _("no domain with matching name '%s'"), dname); src/storage_driver.c: "%s", _("no pool with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); src/storage_driver.c: "%s", _("no storage pool with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); src/storage_driver.c: "%s", _("no storage vol with matching name")); I'm sure there is a number of places where we could add a name there, but it's better left as a separate patch, So commited just removing the two lines for now, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/