Re: [libvirt] [PATCH 16/16] command: Report stdout/stderr if command fails

On Tue, May 10, 2011 at 04:07:55PM -0400, Cole Robinson wrote: > Just reporting the exit status isn't all that enlightening most of the > time. This makes the message pretty wordy, but it will reduce user confusion > for many errors. > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt;

> + virCommandError(VIR_ERR_INTERNAL_ERROR, > + _("Child process (%s) status unexpected: %s\n%s%s"), > + cmdstr ? cmdstr: cmd->args[0], statusstr, > + (out && *out) ? outstr : "", > + (err && *err) ? errstr : ""); > + } > + > + VIR_FREE(outstr); > + VIR_FREE(errstr); > + VIR_FREE(cmdstr); > + VIR_FREE(statusstr); > return -1; > } > } else { Hmm, the stdout/stderr output can be pretty huge for many commands that we run. eg, qemu -help failing could result it a 250 line error message.