Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory
On Fri, Jun 06, 2008 at 11:25:41AM +0100, Daniel P. Berrange wrote:
On Thu, Jun 05, 2008 at 10:30:55PM +0100, Richard W.M. Jones wrote:
>
> +/* Memory peeking flags. */
> +typedef enum {
> + VIR_MEMORY_VIRTUAL = 1, /* addresses are virtual addresses */
> +} virDomainMemoryFlags;
Since there is only one flag, and it is compulsory I'm rather inclined
to say that virtual memory addressing should be the default with a flags
value of 0. Unless there is another mode, not yet implemented, that you
think would be a better default in the future ? Obviously keep the flags
arg for expansion regardless though.
The reason I wanted this flag is because I think this behaviour is
unexpected, so it's worth remarking on it. I would (naively) have
expected a memory-peek call to peek physical memory, even though that
isn't very useful behaviour if you want to actually analyze the
memory. So the flag makes sure people realize that the peeking does a
virtual to physical address mapping. I fully expect that we would add
a VIR_MEMORY_PHYSICAL flag at some point.
Thanks for looking at the rest of the patch. I'll make an updated
version soon with those things fixed.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/