Re: [libvirt] [PATCH 17/24] qemu: Close logfd when closing monitor
On Fri, Nov 13, 2015 at 14:07:42 +0100, Peter Krempa wrote:
On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote:
> Remembering to call qemuMonitorSetDomainLog in the right paths before
> calling qemuProcessStop is annoying and easy to forget. And I already
> forget to do so in commit v1.2.8-52-g0389060: logfd may be leaked if
forgot
> QEMU process dies between Prepare and Finish migration phases.
>
> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> ---
> src/qemu/qemu_monitor.c | 2 ++
> src/qemu/qemu_process.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
ACK
I made the suggested changes and pushed the first 17 patches of this
series. I'll send a v2 of the rest soon. Thanks.
Jirka