[libvirt] [PATCH] test: Drop a few unnecessary <source> elements added by virt-install
The <source mode='bind'/> elements were added in commit 4d7ea75e and
apparently generated by virt-install, but since the @path attribute
is missing, the element will never be formatted back to the XML which the
libvirt-go-xml-check expects, so it fails.
The lack of the @path attribute is not a problem in general, because we
can autogenerate the path in certain cases, so qemuxml2argvtest will
always be happy, but XML formatting is a different thing.
Therefore, drop these generated elements, as they're unnecessary for the
purposes of qemuxml2argvtest and won't mess with the XML formatting
test in Go.
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
---
Additionally, I could introduce a xml2xml test here, but I already spent enough
time hunting the CI failure down between libvirt and libvirt-go so this was the
simplest solution which doesn't require any extra work.
tests/qemuxml2argvdata/aarch64-virt-graphics.xml | 1 -
tests/qemuxml2argvdata/ppc64-pseries-graphics.xml | 1 -
tests/qemuxml2argvdata/x86_64-pc-graphics.xml | 1 -
tests/qemuxml2argvdata/x86_64-q35-graphics.xml | 1 -
4 files changed, 4 deletions(-)
diff --git a/tests/qemuxml2argvdata/aarch64-virt-graphics.xml
b/tests/qemuxml2argvdata/aarch64-virt-graphics.xml
index 95aef91beb..2559cd7950 100644
--- a/tests/qemuxml2argvdata/aarch64-virt-graphics.xml
+++ b/tests/qemuxml2argvdata/aarch64-virt-graphics.xml
@@ -34,7 +34,6 @@
</interface>
<console type="pty"/>
<channel type="unix">
- <source mode="bind"/>
<target type="virtio" name="org.qemu.guest_agent.0"/>
</channel>
<input type="tablet" bus="usb"/>
diff --git a/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml
b/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml
index 3d54a4f171..bab115f666 100644
--- a/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml
+++ b/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml
@@ -28,7 +28,6 @@
</interface>
<console type="pty"/>
<channel type="unix">
- <source mode="bind"/>
<target type="virtio" name="org.qemu.guest_agent.0"/>
</channel>
<input type="tablet" bus="usb"/>
diff --git a/tests/qemuxml2argvdata/x86_64-pc-graphics.xml
b/tests/qemuxml2argvdata/x86_64-pc-graphics.xml
index 03745eabf4..8d8fc14f9f 100644
--- a/tests/qemuxml2argvdata/x86_64-pc-graphics.xml
+++ b/tests/qemuxml2argvdata/x86_64-pc-graphics.xml
@@ -40,7 +40,6 @@
</interface>
<console type="pty"/>
<channel type="unix">
- <source mode="bind"/>
<target type="virtio" name="org.qemu.guest_agent.0"/>
</channel>
<input type="tablet" bus="usb"/>
diff --git a/tests/qemuxml2argvdata/x86_64-q35-graphics.xml
b/tests/qemuxml2argvdata/x86_64-q35-graphics.xml
index 56db898e64..a93b49e480 100644
--- a/tests/qemuxml2argvdata/x86_64-q35-graphics.xml
+++ b/tests/qemuxml2argvdata/x86_64-q35-graphics.xml
@@ -40,7 +40,6 @@
</interface>
<console type="pty"/>
<channel type="unix">
- <source mode="bind"/>
<target type="virtio" name="org.qemu.guest_agent.0"/>
</channel>
<input type="tablet" bus="usb"/>
--
2.20.1