Re: [libvirt] [PATCH] network: fix return value of hostsFileWrite

On 04/28/2011 12:28 AM, Laine Stump wrote: > The lone caller to hostsFileWrite (and the callers for at least 3 > levels up the return stack) assume that the return value will be< 0 > on failure. However, hostsFileWrite returns 0 on success, and a > positive errno on failure. This patch changes hostsFileWrite to return > -errno on failure. > --- > src/util/dnsmasq.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/util/dnsmasq.c b/src/util/dnsmasq.c > index be230e1..2ba9355 100644 > --- a/src/util/dnsmasq.c > +++ b/src/util/dnsmasq.c > @@ -159,19 +159,19 @@ hostsfileWrite(const char *path, > return rc; I had to check context, but here rc is 0 so it is safe. All other lines in the patch are correct. ACK.