Re: [libvirt] [PATCH 14/24] maint: improve VIR_ERR_INVALID_NETWORK usage
On 12/28/2013 11:11 AM, Eric Blake wrote:
When checking for a valid network, we weren't consistent on
whether we reported an invalid network or a connection. Similar
to previous patches, use a common macro to make it nicer.
* src/datatypes.h (virCheckNetworkReturn, virCheckNetworkGoto): New
macros.
(VIR_IS_NETWORK, VIR_IS_CONNECTED_NETWORK): Drop unused macros.
* src/libvirt.c: Use macro throughout.
(virLibNetworkError): Drop unused macro.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/datatypes.h | 29 +++++++++++--
src/libvirt.c | 131 ++++++++++++++++----------------------------------------
2 files changed, 61 insertions(+), 99 deletions(-)
Just making sure it's now expected that virNetworkGetName(),
virNetworkGetUUID(), and virNetworkGetUUIDString() will now have to have
a connected network just like the new requirement for the various domain
API's that previously just cared about a domain regardless of connection.
ACK for the mechanical parts...
John