Re: [RFC PATCH 1/2] node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak
On a Tuesday in 2024, Marc Hartmayer wrote:
On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko
<jtomko(a)redhat.com> wrote:
> On a Wednesday in 2024, Marc Hartmayer wrote:
>>Make sure the old value in `scsi_target->wwpn` is free'd before replacing
it.
>>While at it, simplify the code.
>>
>
> "While at it" usually means it should have been a separate commit,
> especially if the simplification changes the behavior of the code.
>
Looks like this patch has been merged:
5138dd247870 ("node_device_conf: virNodeDeviceGetSCSITargetCaps: fix
memory leak")
Oh, I haven't seen Michal's R-b. Maybe there was a mailing list outage?
Shall we revert it and apply the patch in the mail “[PATCH v1]
node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak”
instead?
I think that if you have to ask, it's not worth the hassle.
Jano
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)