On 07/04/2016 08:17 AM, Daniel P. Berrange wrote:
Way back in 2012, we added the ssize_t.m4.diff file because we didn't want to risk pulling in a gnulib update at time of release.
There is still an upstream bug where gnulib uses the wrong type for ssize_t on mingw; we need the fix now even though it has not yet been accepted into gnulib: https://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00188.html
Fast forward 4 years, and I'm wondering why we stsill have a ssize_t.m4.diff file that we're updating. It doesn't look like gnulib ever merged it upstream. Can we kill it from libvirt too yet, or does gnulib really need to accept it ?
I'll investigate what happens if we drop it, and have a decision later today on the best course forward. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org