Re: [libvirt] [PATCH 2/3] qemu: add support for qemu-xhci USB controller
On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote:
[...]
@@ -3464,7 +3464,7 @@
"ehci", "ich9-ehci1", "ich9-uhci1",
"ich9-uhci2", "ich9-uhci3",
"vt82c686b-uhci", "pci-ohci", "nec-xhci",
"qusb1" (xen pvusb
with qemu backend, version 1.1) or "qusb2" (xen pvusb with qemu
- backend, version 2.0). Additionally,
+ backend, version 2.0), qemu-xhci. Additionally,
Add double quotes around qemu-xhci to conform with the rest
of the documentation. Additionally, having
"nec-xhci", "qusb1" or "qusb2", "qemu-xhci"
looks weird, I think you should change it to
"nec-xhci", "qusb1", "qusb2" or "qemu-xhci"
I won't get into the whole Oxford comma argument ;)
[...]
@@ -0,0 +1,15 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
I like having minimal input files for test cases!
You can make them even smaller, without reducing the test
surface, by getting rid of the <currentMemory> element...
[...]
new file mode 100644
index 0000000000..78d13e0c1e
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml
... and you can get rid of this file altogether by using...
@@ -1416,6 +1416,10 @@ mymain(void)
DO_TEST_PARSE_ERROR("usb-controller-xhci-limit",
QEMU_CAPS_CHARDEV, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_PIIX3_USB_UHCI,
QEMU_CAPS_NEC_USB_XHCI, QEMU_CAPS_NEC_USB_XHCI_PORTS);
+ DO_TEST("usb-controller-qemu-xhci", QEMU_CAPS_DEVICE_QEMU_XHCI);
+ DO_TEST_FAILURE("usb-controller-qemu-xhci-unavailable", NONE);
... "usb-controller-qemu-xhci" again for this test case.
ACK with these issues fixed.
--
Andrea Bolognani / Red Hat / Virtualization