Re: [libvirt] VIR_WARN and VIR_WARN0: many diags were not marked for translation
Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 04:47:50PM +0200, Jim Meyering wrote:
> I noticed some VIR_WARN* uses with unmarked (for translation)
> strings. It turns out there are more than 50:
>
> $ g grep -E 'VIR_WARN0?\(".*"[,)]'|wc -l
> 128
>
> Here's a sample:
>
> src/phyp/phyp_driver.c: VIR_WARN0("Unable to stat local file.");
> src/phyp/phyp_driver.c: VIR_WARN0("Unable to open local file.");
> src/qemu/qemu_conf.c: VIR_WARN0("Failed to get host CPU");
Historically we have avoided marking our debugging messages
for translation. These messages generally aren't useful for
end users, their core purpose is to assist package maintainers
& developers receiving bug reports in identifying the problem.
Getting bug reports with these messages in non-english languages
makes life harder.
Nonetheless, many of my manual changes highlighted
existing (bogus) attempts to translate VIR_WARN0? diagnostics.
Those should be addressed regardless.
Considering the large number of existing VIR_WARN uses with strings
marked for translation, do you want to reconsider?
$ g grep 'VIR_WARN.*_('|wc -l
60
or would you prefer to remove the _(...) marks on those 60 uses?