6 Jul
2011
6 Jul
'11
3:10 p.m.
On 07/06/2011 07:31 AM, Matthias Bolte wrote:
2011/7/6 Laine Stump<laine@laine.org>:
Otherwise this will leak an fd each time one of these functions is called. --- src/util/interface.c | 36 ++++++++++++++++++++++++++---------- 1 files changed, 26 insertions(+), 10 deletions(-) + +err_exit: + VIR_FORCE_CLOSE(fd); + return rc; } HACKING suggests to call the label cleanup instead of err_exit in both functions.
Yeah, but all the other functions in that file had err_exit, and I wanted to be consistent within the file, but didn't want to rename everything.
ACK, with the labels renamed.
Only if you'll ACK a separate patch that renames the other labels :-)