Re: [Libvir] Add 'console' and 'vncdisplay' commands to virsh
On Fri, Jan 26, 2007 at 05:34:35AM -0500, Daniel Veillard wrote:
On Fri, Jan 26, 2007 at 02:58:27AM +0000, Daniel P. Berrange wrote:
>
> The attached patch adds two new commands to virsh:
>
> - console - connects to the guest's serial console
> - vncdisplay - outputs the ip address & port number of a guest vnc display
>
> The former is another stage in eliminating the need to run 'xm' - replacing
> the Xen specific 'xm console' code, with the added advantage of working
> with any libvirt backend driver.
Very cool. I wonder if we should not move out virsh specific code to
a new separate subdir, like for the proxy to clean things up a bit in src/
There's only three files for virsh in there soo far which isn't too many,
so for now I think its fine having it in one place. It makes life easier
with building/testing too because you can build libvirt & run virsh to test
it without changing dirs.
> The vncdisplay is intended to make it easier for people to
launch a
> VNC viewer process. It prints out a IP address & port number in a format
> suitable for passing to vncviewer on the command line, eg
>
> vncviewer `virsh vncdisplay myguest`
Okay, the other option would have been to fork vncviewer directly,
but that's more generic. Seems however that would be incomplete if connecting
to a remote xend, but that's something we should be able to do properly
once we have remote support integrated.
I've commited the patches now.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|