Re: [libvirt] PATCH: 2/14: Generic network XML parser/formatter

Modulo some minor problems, ACK. Even though I reviewed only the incremental diffs, there was a bit of new material. BTW, nice catch, with the new uses of virBufferEscapeString. > +virNetworkDefPtr virNetworkDefParseNode(virConnectPtr conn, > + xmlDocPtr xml, > + xmlNodePtr root) > +{ > + xmlXPathContextPtr ctxt = NULL; > + virNetworkDefPtr def = NULL; > + > + if (!xmlStrEqual(root->name, BAD_CAST "network")) { > + virNetworkReportError(conn, VIR_ERR_INTERNAL_ERROR, > + "%s", _("incorrect root element")); > + goto cleanup; > + } No big deal, but the above goto could be "return NULL;".