Re: [libvirt] [PATCHv2 02/33] qemu: Make qemuDomainPrepareDiskChainElement aware of remote storage
On 05/22/14 23:58, Eric Blake wrote:
On 05/22/2014 07:47 AM, Peter Krempa wrote:
> Refactor the function to accept a virStorageSourcePtr instead of just
> the path, add a check to run it only on local storage and fix callers
> (possibly by using a newly introduced wrapper that wraps a path in the
> virStorageSource struct for legacy code)
> ---
>
> Notes:
> Version 2:
> - V1 acked by Eric with comment cleanup
ACK still holds.
This is a large series; you should go ahead and push ACK'd patches
(especially if it is before the 1.2.5 freeze) rather than waiting for a
full-series review, unless stated explicitly in a patch, or until I hit
something that requires rework that might affect later patches. [that,
and I have patches for live commit that I'm waiting to rebase on top of
yours...]
Well in one of my previous large series I've pushed some code that was
already ACKed at a start of the series which later ended up unused due
to changes later in the series and I was reverting those changes. Thus I
usually rather keep them private until I'm sure that it will be used.
Said that, I'm going to start pushing this series partially as it's
getting tedious for me to spin that amount of patches around.
Peter
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)