Re: [libvirt] [PATCH] qemu: nicer error message on failed graceful destroy

On 02/22/2012 01:49 PM, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=795656 mentions > that a graceful destroy request can time out, meaning that the > error message is user-visible and should be more appropriate > than just internal error. > > * src/qemu/qemu_driver.c (qemuDomainDestroyFlags): Swap error type. > --- > src/qemu/qemu_driver.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 717bdf1..c7ca881 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -1792,7 +1792,7 @@ qemuDomainDestroyFlags(virDomainPtr dom, > */ > if (flags & VIR_DOMAIN_DESTROY_GRACEFUL) { > if (qemuProcessKill(driver, vm, 0) < 0) { > - qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", > + qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", > _("failed to kill qemu process with SIGTERM")); > goto cleanup; > } ACK.