Re: [libvirt] [PATCH 3/7] util: Resolve Coverity FORWARD_NULL

Convert virPCIDriverDir to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; --- src/util/virpci.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 5d86c89..5dabb61 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c

@@ -998,7 +997,7 @@ virPCIProbeStubDriver(const char *driver) bool probed = false; recheck: - if (virPCIDriverDir(&drvpath, driver) == 0 && virFileExists(drvpath)) { + if ((drvpath = virPCIDriverDir(driver)) && virFileExists(drvpath)) {

/* driver already loaded, return */ VIR_FREE(drvpath); return 0;