Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables
On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote:
On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote:
> On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote:
> > > So how about storing 2 sets of expected data for this test case.
> > >
>
> Two is not enough. My clang 5.0.1 produces a test that displays the
> monkeys correctly, but does not count their width properly:
Is this a different bug though ? The issue with iswprint() is varying
according to glibc version, not compiler version.
The broken setup is:
sys-libs/glibc-2.25-r9
sys-devel/clang-5.0.1
It works on:
sys-libs/glibc-2.26-r7
with either of:
sys-devel/clang-5.0.1
sys-devel/clang-6.0.1
So yes, it is a glibc bug.
Depending on the version, either just wcwidth returns incorrect values
for the monkeys (my case) or iswprint considers them non-printable.
So I wonder if the clang problem you mention is something that can be
fixed in some way ?
Nope, red herring. My maint point was that there are more than 2
possible results.
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)