Re: [PATCH] meson: Only check for openwsman if hyperv is enabled
On 8/28/20 2:00 AM, Pavel Hrdina wrote:
On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote:
> Running meson configure with '-Ddriver_hyperv=disabled' fails with
>
> meson.build:1252:0: ERROR: Dependency "openwsman" not found, tried
> pkgconfig and cmake
>
> openwsman is only required if the hyperv driver is enabled. Don't
> check for it if hyperv is disabled.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
>
> There are likely other ways to fix the problem, this being a meson
> noobish one :-).
You are probably using some other options as well because running:
meson build -Ddriver_hyperv=disabled
will not fail if openwsman is missing. The default for openwsman is
'auto'.
I stumbled across it while doing downstream packaging work on 6.7.0. hyperv is
the only thing that requires openwsman and I have it disabled. Here's the full
meson invocation from the build log
/usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64
--libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin
--includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man
--infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc
--localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload
--auto-features=enabled . build --libexecdir=/usr/lib64/libvirt
-Drunstatedir=/run -Ddriver_qemu=enabled -Ddriver_openvz=enabled
-Ddriver_lxc=enabled -Ddriver_vbox=disabled -Ddriver_libxl=enabled
-Dsasl=enabled -Dpolkit=enabled -Ddriver_libvirtd=enabled -Ddriver_esx=enabled
-Ddriver_hyperv=disabled -Ddriver_vmware=enabled -Ddriver_vz=disabled
-Ddriver_bhyve=disabled -Dremote_default_mode=legacy -Ddriver_interface=enabled
-Ddriver_network=enabled -Dstorage_fs=enabled -Dstorage_lvm=enabled
-Dstorage_iscsi=enabled -Dstorage_scsi=enabled -Dstorage_disk=enabled
-Dstorage_mpath=enabled -Dstorage_rbd=enabled -Dstorage_sheepdog=disabled
-Dstorage_gluster=enabled -Dstorage_iscsi_direct=enabled -Dstorage_zfs=disabled
-Dstorage_vstorage=disabled -Dnumactl=enabled -Dnumad=enabled -Dcapng=enabled
-Dfuse=enabled -Dnetcf=disabled -Dnetcontrol=enabled -Dselinux=enabled
-Dselinux_mount=/selinux -Dapparmor=enabled -Dapparmor_profiles=true
-Dhal=disabled -Dudev=enabled -Dyajl=enabled -Dsanlock=enabled -Dlibpcap=enabled
-Dmacvtap=enabled -Daudit=enabled -Ddtrace=enabled -Dfirewalld=enabled
-Dfirewalld_zone=enabled -Dwireshark_dissector=enabled -Dnss=enabled
-Dqemu_user=qemu -Dqemu_group=qemu -Dlogin_shell=disabled -Dinit_script=systemd
...
meson.build:1258:0: ERROR: Dependency "openwsman" not found, tried pkgconfig and
cmake
Regards,
Jim