Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

On Wed, 18 Jul 2007 04:16:36 -0400 Daniel Veillard wrote: Hi, The schedinfo command said strange message. # virsh schedinfo 25 --weight 0 libvir: Xen error : invalid argument in xenHypervisorSetSchedulerParameters: Credit scheduler weight parameter (%d) is out of range (1-65535) ^^^^here # virsh schedinfo 25 --cap -1 libvir: Xen error : invalid argument in xenHypervisorSetSchedulerParameters: Credit scheduler cap parameter (%d) is out of range (0-65535) ^^^^here I think we do not need to print the specified number, so I removed "(%d)" from the code to solve this problem. If you want to print the specified number, I will remake this patch ! And I found some wrong code when I was checking about error message. So I fix them, but if I have a misunderstanding of them, please tell me. :-) o I guess 10th argument of __virRaiseError should be specified the number of the line. But the value, for example which is number of heypercall, is sometimes specified. --- xen_internal.c-673- errmsg = __virErrorMsg(error, info); xen_internal.c:674: __virRaiseError(NULL, NULL, NULL, VIR_FROM_XEN, error, VIR_ERR_ERROR, xen_internal.c-675- errmsg, info, NULL, value, 0, errmsg, info); xen_internal.c-676-} There is same mistake at xml.c, xmlrpc.c and xend_internal.c, too. Thanks, Saori Fukuta