Re: [libvirt] [PATCH v2 13/31] qemu: Probe CPU models for KVM and TCG
On Mon, Nov 21, 2016 at 12:21:09AM +0100, Jiri Denemark wrote:
CPU models (and especially some additional details which we will
start
probing for later) differ depending on the accelerator. Thus we need to
call query-cpu-definitions in both KVM and TCG mode to get all data we
want.
Tests in tests/domaincapstest.c are temporarily switched to TCG to avoid
having to squash even more stuff into this single patch. They will all
be switched back later in separate commits.
That could be avoided by moving this patch after patch
"tests: Update capabilities for QEMU 2.7.0". Code from this patch is required
to use qemucapsprobe to generate updated *.replies, but I think that the updated
replies can be pushed before this patch is introduced.
This is just a suggestion, so you don't have to do it, but it would probably
made the patches cleaner.
ACK
Pavel
Attachments:
- signature.asc (application/pgp-signature — 801 bytes)