Re: [libvirt] distcheck issues on maint and master

On Mon, Aug 13, 2012 at 09:56:49AM -0400, Cole Robinson wrote: > I just pushed a bunch of patches to -maint branches, but both are giving me > distcheck errors that seem related to a gnulib update: > > ERROR: files left in build directory after distclean: > ./.sc-start-sc_vulnerable_makefile_CVE-2012-3386 > > Any hints? You need to grab the automake RPM from Fedora 18.

> > > > I tried to reproduce on master, but it has its own set of issues: > > IOError: [Errno 13] Permission denied: '../../src/hyperv/hyperv_wmi.generated.h' > types_typedef = open_and_print(os.path.join(output_dirname, > "esx_vi_types.generated.typedef")) > File "../../src/esx/esx_vi_generator.py", line 1492, in open_and_print > return open(filename, "wb") > IOError: [Errno 13] Permission denied: > '../../src/esx/esx_vi_types.generated.typedef' > make[3]: *** [.hyperv_wmi_generator.stamp] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[3]: *** [.esx_vi_generator.stamp] Error 1 > > I can get past that with: > > $ git revert 1bfb47dfe61c3cf9a716db072cbe22f26e980081 > [master f5a9a90] Revert "Make ESX & Hyper-V code generator safe with parallel > builds" Wierd, I don't understand how that change would cause a EPERM error when generating the output file.

> Then I get: > > GEN check-symfile > Can't open perl script "../../src/check-symfile.pl": No such file or directory > make[4]: *** [check-symfile] Error 2 > > Which I fixed with: > > $ git diff > diff --git a/src/Makefile.am b/src/Makefile.am > index 5ae84b1..a5223f2 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -331,7 +331,7 @@ else !WITH_REMOTE > # re-generated when configured --without-remote. > check-protocol: > endif > -EXTRA_DIST += $(PROTOCOL_STRUCTS) > +EXTRA_DIST += $(PROTOCOL_STRUCTS) check-symfile.pl > check-local: check-protocol check-symfile > .PHONY: check-protocol $(PROTOCOL_STRUCTS:structs=struct) ACK to this fix.