Re: [libvirt] [PATCH 1/3] Remove support for old kernels lacking private devpts
On Wed, Apr 03, 2013 at 10:59:04AM -0600, Eric Blake wrote:
On 04/03/2013 10:02 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> Early on kernel support for private devpts was not widespread,
> so we had compatibiltiy codepaths. Such old kernels are not
> seriously used for LXC these days, so the compat code can go
> away
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> src/lxc/lxc_controller.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
ACK.
We already reject compilation of LXC on RHEL 5 due to other
configure-time checks; is this something worth turning into an
additional configure test of whether a kernel is new enough, or are we
okay with just leaving it as a runtime test?
We can't ever check kernels during configure time, because you can't
assume the build kernel matches the distro kernel. eg all Fedora builds
are done in a host with a RHEL kernel
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|