On Fri, 2019-05-03 at 16:41 +0100, Daniel P. Berrangé wrote:
On Fri, May 03, 2019 at 05:37:58PM +0200, Andrea Bolognani wrote:
> > @@ -461,8 +462,12 @@ class Application:
> > "git_branch": git_branch,
> > })
> >
> > + ap_path =
distutils.spawn.find_executable("ansible-playbook")
>
> Please call this 'ansible_playbook' instead of 'ap_path'...
>
> > @@ -534,8 +539,12 @@ class Application:
> > # a kernel argument
> > extra_arg = "console=ttyS0
ks=file:/{}".format(install_config)
> >
> > + vi_path =
distutils.spawn.find_executable("virt-install")
>
> ... and same here.
I'll call this one "virt_install" rather than "ansible_playbook"
;-P
Since you insist, I'll begrudgingly accept this compromise :P
--
Andrea Bolognani / Red Hat / Virtualization