Re: [libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice
On Thu, Jul 14, 2016 at 02:27:40PM +0200, Martin Kletzander wrote:
When reinitializing Ploop volumes we also went through the rutine of
the
normal wipe, effectively removing the root.hds file twice.
The file was wiped with the selected algorithm first (without deletion),
then reinitialized to make sure you can delete it via libvirt later.
We could get rid of the reinitialization if we make sure libvirt can
operate on the volume (after wiping, pretty much only delete makes
sense), but removing the actual wiping is wrong.
Jan
Since we'll
hopefully add support for other formats as well, split the function with
a switch into which we can cleanly add formats in the future.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
src/storage/storage_backend.c | 49 ++++++++++++++++++++++++-------------------
1 file changed, 27 insertions(+), 22 deletions(-)