On 06/22/2016 01:37 PM, Laine Stump wrote:
virNetDevLinkDump should have been in virnetlink.c, but that file
didn't exist yet when the function was created. It didn't really
matter until now - I found that having virnetlink.h included by
virnetdev.h caused build problems when trying to #include virnetdev.h
in a .c file in src/conf (due to missing directory in -I). Rather than
fix that to further institutionalize the incorrect placement of this
one function, this patch moves the function.
---
src/libvirt_private.syms | 2 +-
src/util/virnetdev.c | 134 +-------------------------------------
src/util/virnetdev.h | 6 --
src/util/virnetdevvportprofile.c | 4 +-
src/util/virnetlink.c | 135 +++++++++++++++++++++++++++++++++++++++
src/util/virnetlink.h | 5 ++
6 files changed, 145 insertions(+), 141 deletions(-)
Let's see if I can clear a few off the starboard side... Start getting
some of these in before something else changes that causes a ripple effect.
ACK
John