Re: [libvirt] [PATCH] fix LSB part of virtlogd runlevel script
On Wed, Dec 02, 2015 at 08:52:28AM +0100, Olaf Hering wrote:
On Wed, Dec 02, Martin Kletzander wrote:
> But seeing this patch, we should also fix other init scripts, I believe.
> I, personally, see only the same problem in
> src/locking/virtlockd.init.in, but I didn't use the script you used.
virtlockd.init happens to work for me because there is a local patch
which fixes its shortcomings. I noticed this patch just now.
Feel free to contribute the patches as well if you can. We would love
to have such things fixed, which would also fix it for others without
the need for some patches downstream needed to be applied (that's big
part of the openness ;) )
There are other bugs in sysv scripts. xen has --with-initddir and
other
knobs to make its source not RedHat-only. If I find the time I can port
these knobs to libvirt, if anyone actually cares.
That would be wonderful to have fixes for those that are libvirt-related
(to my knowledge libvirt-guests, libvirtd, virtlockd and lately
virtlogd). Of course we care about that. For other projects that is to
be discussed on their respective mailing-lists (or whatever way of
communication channel they tend to use).
Thank you for the time and the patches, I'm looking forward to those.
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)