Re: [libvirt] [PATCH 1/3] Fixed reference count in pool-build

21 Feb 2010

On Thu, Feb 18, 2010 at 05:58:05PM -0500, David Allan wrote:
...
---
 tools/virsh.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index e1d1300..bd6b6be 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -4036,9 +4036,10 @@ cmdPoolBuild(vshControl *ctl, const vshCmd *cmd)
     } else {
         vshError(ctl, _("Failed to build pool %s"), name);
         ret = FALSE;
-        virStoragePoolFree(pool);
     }
+    virStoragePoolFree(pool);
+
     return ret;
 }
Looks fine, ACK, pushed !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

    