Re: [libvirt] [PATCH V14 4/5] nwfilter: Add multiple IP address support to DHCP snooping

On 05/25/2012 05:56 AM, Stefan Berger wrote: > With support for multiple IP addresses per interface in place, this patch > now adds support for multiple IP addresses per interface for the DHCP > snooping code. > > > Testing: > > Since the infrastructure I tested this with does not provide multiple IP > addresses per MAC address (anymore), I either had to plug the VM's interface > from the virtual bride connected directly to the infrastructure to virbr0 > to get a 2nd IP address from dnsmasq (kill and run dhclient inside the VM) > or changed the lease file (/var/run/libvirt/network/nwfilter.leases) and > restart libvirtd to have a 2nd IP address on an existing interface. > Note that dnsmasq can take a lease timeout parameter as part of the --dhcp-range > command line parameter, so that timeouts can be tested that way > (--dhcp-range 192.168.122.2,192.168.122.254,120). So, terminating and restarting > dnsmasq with that parameter is another choice to watch an IP address disappear > after 120 seconds. > > Regards, > Stefan > > --- > src/nwfilter/nwfilter_dhcpsnoop.c | 107 +++++++++++++++++++++++--------------- > 1 file changed, 67 insertions(+), 40 deletions(-) I'm not in a position to runtime test this, but it did pass my compile tests and looked clean from inspection. ACK.