Re: [libvirt] [PATCH 1/4] New APIs to manage saved-state & core-dump files.

> +int virConnectNumOfSavedImages (virConnectPtr conn); > +int virConnectListSavedImages (virConnectPtr conn, > + char **const files, > + int maxfiles); > +int virSavedImageRemove (virConnectPtr conn, > + const char *file); > +int virSavedImageDownload (virConnectPtr conn, > + virStreamPtr stream, > + const char *file); THis looks very much like it is tending towards re-inventing most of the existing snapshot and/or managed save functionality.

> @@ -1101,6 +1110,15 @@ int virDomainManagedSaveRemove(virDomainPtr dom, > int virDomainCoreDump (virDomainPtr domain, > const char *to, > unsigned int flags); > +int virConnectNumOfCoreDumps(virConnectPtr conn); > +int virConnectListCoreDumps (virConnectPtr conn, > + char **const files, > + int maxfiles); > +int virCoreDumpRemove (virConnectPtr conn, > + const char *file); > +int virCoreDumpDownload (virConnectPtr conn, > + virStreamPtr stream, > + const char *file); This is slightly more palatable. IMHO we do want some kind of 'managed core dump' functionality to associate these APIs with, since we can't change the semantics of the existing virDOmainCoreDump API. ie we want something like virDomainManagedCoreDump(virDomainPtr dom, int flags); and now libvirt will pick the core dump filename, probably based on date. Daniel