Re: [libvirt] [PATCH 2/4] viralloc: Honor const correctness in VIR_FREE

This definition was doing two things - casting away const, AND doing type validation. virFree(&foo) will compile even if foo is an int, but we want to ensure that foo is of type char*. I think what you want is: # define VIR_FREE(ptr) virFree(1 ? &(ptr) : (ptr)) > -# else > -/* The Coverity static analyzer considers the else path of the "?:" and > - * flags the VIR_FREE() of the address of the address of memory as a > - * RESOURCE_LEAK resulting in numerous false positives (eg, VIR_FREE(&ptr)) > - */ > -# define VIR_FREE(ptr) virFree((void *) &(ptr)) and keep this alternative to hush up coverity.