Re: [libvirt] [V2 Patch] virsh: Change log level order

On 05/20/2011 03:36 AM, Daniel P. Berrange wrote: Unfortunately, I tried to apply this patch in order to pick out just the magic number removals, but your mailer mungled it beyond the point that git could understand it. Can you fix the issues we've identified, including splitting this patch into two pieces (one with just the magic number removal, another with my suggestion of factoring the log level comparison into a helper function, and then just tweaking the helper function and command line -d parsing to nicely map log levels to the same values as for libvirtd)? Also, since your mailer seems to be conspiring against us, have you tried 'git send-email'? Or attaching rather than sending inline? Practice sending mail to yourself, and running that file through 'git am' to see what sort of problems we might have applying your patch. Or, you could post a link to a public repository (github or repo.or.cz are both decent choices) with your commits pre-applied, to bypass your mailer idiosyncrasies. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org