-----Original Message----- From: Daniel P. Berrangé <berrange@redhat.com> Sent: Tuesday, July 20, 2021 5:08 PM To: Huang, Haibin <haibin.huang@intel.com> Cc: libvir-list@redhat.com; Ding, Jian-feng <jian-feng.ding@intel.com>; Yang, Lin A <lin.a.yang@intel.com>; Lu, Lianhao <lianhao.lu@intel.com> Subject: Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX
On Thu, Jul 01, 2021 at 08:10:28PM +0800, Haibin Huang wrote:
From: Lin Yang <lin.a.yang@intel.com>
If SGX is defined in domain, add the argument to enable SGX in -cpu <model>:
-cpu <model>,+sgx,+sgx-debug,+sgx1,+sgx-encls-c, +sgx-enclv,+sgx-exinfo,+sgx-kss,+sgx-mode64, +sgx-provisionkey,+sgx-tokenkey,+sgx2,+sgxlc --- src/qemu/qemu_command.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2c3785886c..fb05acbc94 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6405,6 +6405,12 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
case VIR_CPU_MODE_CUSTOM: virBufferAdd(buf, cpu->model, -1); + if(def->sgx) + virBufferAdd(buf, + ",+sgx,+sgx-debug,+sgx1,+sgx-encls-c,+sgx-enclv,+sgx-exinfo," + "+sgx-kss,+sgx-mode64,+sgx-provisionkey,+sgx- tokenkey,+sgx2," + "+sgxlc", + -1);
+feature syntax in QEMU is deprecated. It should be feature=on
[Haibin] ok, got it, I will modify it.
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|