7 Mar
2019
7 Mar
'19
10:56 a.m.
On Thu, Mar 07, 2019 at 09:11:45AM +0100, Peter Krempa wrote:
On Wed, Mar 06, 2019 at 19:16:47 +0100, Pavel Hrdina wrote:
This way if the first test "full" fails we will run the second test as well.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- tests/storagepoolcapstest.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
ACK, that's the way almost all our test files use.
Alternatively by using VIR_AUTOUNREF for both 'fullCaps' and 'fsCaps' you can get rid of the whole cleanup label and just return -1 if any of the virCapabilitiesNew calls fails. Then use 'ret' only in DO_TEST.
Good point, I'll post a followup patch that will use VIR_AUTOUNREF for the whole file. Thanks Pavel