Re: [libvirt] [PATCH 1/5] conf: allow different resource registration modes
I'm so sorry for not getting to this earlier. I though I'll get to this over
the holidays, but they were very busy with no free time for me.
On Wed, Dec 20, 2017 at 04:47:46PM +0000, Daniel P. Berrange wrote:
Currently the QEMU driver has three ways of setting up cgroups. It
either
skips them entirely (if non-root), or uses systemd-machined, or uses
cgroups directly.
So what we are trying to fix here is that all of the variations don't create the
same structure. So it needs to be clear for the mgmt app to guess^Wknow
correctly where the domain is in the cgroup hierarchy.
It is further possible to register directly with systemd and bypass
machined. We don't support this by systemd-nsspawn does and we ought
to.
But what's the benefit of that?
This change adds ability to configure the mechanism for registering
resources between all these options explicitly. via
<resource register="none|direct|machined|systemd"/>
I understand what you are trying to fix, but I don't quite follow why we should
expose that. Can't we guess some of them easily? Or are you making this part
of the PoC, but then removing it later?
For now I am OK with that, but I would rather see that as a part of qemu.conf
(or libvirtd.conf), not really in the XML. OK for the PoC, though.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)