Re: [libvirt] [PATCH] fix MinGW compilation(200808)
On Mon, Aug 11, 2008 at 10:41:43AM +0200, Jim Meyering wrote:
Atsushi SAKAI <sakaia(a)jp.fujitsu.com> wrote:
> I am looking around the code about WEXITSTATUS.
> It seems that following kind of code needs on gnulib.
> http://kerneltrap.org/mailarchive/git/2008/2/27/1003054
> What do you think?
Hi Atsushi,
Yes, git provides MinGW support, and I see it's compat/mingw.h
includes this line:
#define WEXITSTATUS(x) ((x) & 0xff)
Could it be as easy as adding this?
#ifndef WEXITSTATUS
# define WEXITSTATUS(x) ((x) & 0xff)
#endif
Just adding that to virsh (or one of the libvirt headers) is fine by me.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|