Re: [libvirt] [PATCH] conf: Improve incorrect root element error messages
On 11/28/2011 08:49 AM, Eric Blake wrote:
> +++ b/src/security/virt-aa-helper.c
> @@ -644,7 +644,7 @@ caps_mockup(vahControl * ctl, const char *xmlStr)
> }
>
> if (!xmlStrEqual(ctxt->node->name, BAD_CAST "domain")) {
> - vah_error(NULL, 0, _("incorrect root element"));
> + vah_error(NULL, 0, _("unexpected root element, expecting
<domain>"));
this one does not.
ACK with virt-aa-helper fixed to be like the others.
It turns out the problem here is that vah_error is hard-coded to taking
one string argument, instead of being a var-args like most other error
reporting methods. We should fix that, as a separate patch.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)