Re: [libvirt] [Xen-devel] [xen-unstable bisection] complete build-i386-libvirt

Dario Faggioli wrote: > > I like patch1 better, but I think it can cause "unused variable" like > warnings if, at some point in future, we will actually use the new soft > affinity parameter, when compiling on a version of libxl that does not > define HAVE_VCPUINFO_SOFT_AFFINITY, can't it? Yes. > If yes, is it an issue? As you say, only when the new parameter is actually used. But that will cause build failures when warnings are treated as errors. > If yes, a big enough one to make us prefer patch2? > Yes, I think so. And as mentioned above, it is similar to how other LIBXL_HAVE_ is handled.