[PATCH 4/9] virDomainFeaturesTCGDefParse: Don't leak 'tcg_features' when '<tcg>' feature is repeated

Similarly to other cases users may specify the feature flag multiple times. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- src/conf/domain_conf.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e31b674bc2..0f0488f3a2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16807,21 +16807,25 @@ virDomainFeaturesTCGDefParse(virDomainDef *def, xmlXPathContextPtr ctxt, xmlNodePtr node) { - g_autofree virDomainFeatureTCG *tcg = NULL; + unsigned long long tb_cache; VIR_XPATH_NODE_AUTORESTORE(ctxt); - tcg = g_new0(virDomainFeatureTCG, 1); ctxt->node = node; if (virDomainParseMemory("./tb-cache", "./tb-cache/@unit", - ctxt, &tcg->tb_cache, false, false) < 0) + ctxt, &tb_cache, false, false) < 0) return -1; - if (tcg->tb_cache == 0) + if (tb_cache == 0) return 0; + if (!def->tcg_features) + def->tcg_features = g_new0(virDomainFeatureTCG, 1); + + def->tcg_features->tb_cache = tb_cache; + + def->features[VIR_DOMAIN_FEATURE_TCG] = VIR_TRISTATE_SWITCH_ON; - def->tcg_features = g_steal_pointer(&tcg); return 0; } -- 2.46.0