Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine
On Mon, Feb 7, 2022 at 4:58 PM Peter Krempa <pkrempa(a)redhat.com> wrote:
On Mon, Feb 07, 2022 at 16:50:28 +0530, Ani Sinha wrote:
> On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa <pkrempa(a)redhat.com> wrote:
> > > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa
wrote:
> > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote:
> > > > On Mon, 7 Feb 2022 09:14:37 +0100
> > > > Igor Mammedov <imammedo(a)redhat.com> wrote:
> > > [...]
> > > > Even if we change it in libvirt right away,
changing qemu will break
> > > forward compatibility. While we don't guarantee it, it still creates
> > > user grief.
> > > I've filed an upstream issue:
> > > https://gitlab.com/libvirt/libvirt/-/issues/272
> I can look into this bug. Feel free to assign it to me.
No need to. I've noticed that we already call query-hotpluggable-cpus
so with a simple modification the VM startup code path can be easily
fixed so I've done so.
Ok I will look for your patch in the mailing list and review them.