Re: [Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen
On Tue, Jul 24, 2007 at 10:32:34AM -0700, David Lutterkort wrote:
For HVM Xen, state that ACPI and APIC can be turned on and off.
Looks fine to me except for the point raised by Anthony and
some cleanup:
if (r == -1) goto vir_buffer_failed;
}
+ if (guest_archs[i].hvm) {
+ r = virBufferAdd (xml,
+ "\
+ <acpi default=\"on\" toggle=\"yes\"/>\n\
+ <apic default=\"on\" toggle=\"yes\"/>\n", -1);
+ if (r == -1) goto vir_buffer_failed;
+ }
r = virBufferAdd (xml,
"\
use ' for the delimiters of attributes values, that way you don't
need an escaping, and as in previous patch I dislikethe way strings
are cut for indenting at the C level.
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/