Daniel Veillard <veillard(a)redhat.com> wrote:
On Sun, Mar 23, 2008 at 07:50:24PM +0100, Guido Günther wrote:
> This patch marks the error messages in qemu_driver.c as translatable,
> some of them were marked as such already. Please apply.
[...]
> qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
> - "cannot create bridge '%s' : %s", name,
strerror(err));
> + _("cannot create bridge '%s' : %)"),
name, strerror(err));
Patch is a bit broken here, otherwise that looks fine. I'm wondering why
that wasn't check by 'make syntax-check' as other modules are checked for
translatable strings.
I explained why, fixed the underlying problem,
and fixed about 1/3 of the violations it exposed
with this big patch:
http://thread.gmane.org/gmane.comp.emulators.libvirt/5374
But for your objection, I would have applied that change weeks ago.
I've been waiting for a reply to my question at the end of the thread:
http://thread.gmane.org/gmane.comp.emulators.libvirt/5374/focus=5382