Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage
On Mon, Jun 08, 2009 at 02:55:02PM -0400, Dave Allan wrote:
Daniel Veillard wrote:
>On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote:
>>---
>> src/node_device_conf.c | 5 +++++
>> src/node_device_conf.h | 1 +
>> src/node_device_hal.c | 1 +
>> 3 files changed, 7 insertions(+), 0 deletions(-)
>
> Patch looks fine to me, my main question is if we can get the same
>thing from devkit backend.
It doesn't look to me like any of the storage stuff is implemented for
devkit, so I'm not sure what's going to be required there. It's a good
question, though.
The position of DeviceKit developers is that it will be a sub-set of the
HAL functionality. Some of the functionality will only be provided by
the lower level udev or even sysfs, and other functionality will only
be available via higher level like DeviceKit-disks. So I would not
be at all suprised if we can't get serial number from DeviceKit, but
there will be *somewhere* we can get it.... Yes, for libvirt's needs
it looks like the new DeviceKit will be more work for us, compared to
HAL :-(
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|